[Beignet] [QA 2013/12/10] Status of Piglit test cases

[Zhigang Gong]

The failure: API/clCreateBuffer: fail, is a regression and is caused by the following commit:

commit 2d5b522b112847daaa8385b7db106d16fc86c8c3
Author: Yang Rong <rong.r.yang at intel.com>
Date:   Wed Nov 27 14:06:50 2013 +0800

    Enlarge the global mem size.

    When create image, due to alignment, will casue size large than max alloc size.
    Enlarge the global memory size and using it to check size when alloc.

    Signed-off-by: Yang Rong <rong.r.yang at intel.com>
    Reviewed-by: Zhigang Gong <zhigang.gong at linux.intel.com>


But from my point of view, this may not be a failure according to the OCL spec.

Please refer the section 5.2.1:

       errcode_ret:
       ...
       CL_INVALID_BUFFER_SIZE if size is 0.

       *Implementations may return CL_INVALID_BUFFER_SIZE if size is greater than
       CL_DEVICE_MAX_MEM_ALLOC_SIZE value specified in table 4.3 for all devices in context.

You can see that the spec doesn't require to return CL_INVALID_BUFFER_SIZE if
size is greater than CL_DEVICE_MAX_MEM_ALLOC_SIZE. It uses *may* which means it
should up to the implementation.

On Wed, Dec 11, 2013 at 02:46:20AM +0000, Zou, Nanhai wrote:
> Never mind,  I see the cases.
> Those skipped cases are caused by fp64 extension which we do not enabled.
> 
> However Program/Build/vector-operators is verctor ++ -- issue which is supposed to be fixed by llvm 3.4...
> We will check that.
> 
> Thanks
> Zou Nanhai
> 
> 
> 
> From: beignet-bounces at lists.freedesktop.org [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Zou, Nanhai
> Sent: Wednesday, December 11, 2013 10:14 AM
> To: Sun, Yi; 'beignet at lists.freedesktop.org'
> Cc: Jin, Gordon
> Subject: Re: [Beignet] [QA 2013/12/10] Status of Piglit test cases
> 
> Hi,
> Can you list the 4 failures?
> 
> Thanks
> Zou Nanhai
> 
> From: Sun, Yi
> Sent: Wednesday, December 11, 2013 12:17 AM
> To: 'beignet at lists.freedesktop.org'; Zou, Nanhai
> Cc: Jin, Gordon
> Subject: RE: [Beignet] [QA 2013/12/10] Status of Piglit test cases
> 
> There is no difference after updating LLVM to version 3.4.
> #clang --version
> clang version 3.4 (http://llvm.org/git/clang.git 5fc0070c015443745ea4705765d4332079a0f95e) (http://llvm.org/git/llvm.git cdf67d5791d044a5f217114e18eb8d6242222b98)
> Target: x86_64-unknown-linux-gnu
> Thread model: posix
> 
> summary:
>        pass: 1495
>        fail: 4
>       crash: 0
>        skip: 11
>        warn: 0
> dmesg-warn: 0
> dmesg-fail: 0
>       total: 1510
> 
> Thanks
>   --Sun, Yi
> 
> From: beignet-bounces at lists.freedesktop.org<mailto:beignet-bounces at lists.freedesktop.org> [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Sun, Yi
> Sent: Tuesday, December 10, 2013 10:23 PM
> To: 'beignet at lists.freedesktop.org'
> Cc: Zou, Nanhai; Jin, Gordon
> Subject: [Beignet] [QA 2013/12/10] Status of Piglit test cases
> 
> Pass rate: 99.07%
> summary:
>        pass: 1495
>        fail: 4
>       crash: 0
>        skip: 11  (one out of them is 'should skip')
>        warn: 0
>  dmesg-warn: 0
>  dmesg-fail: 0
>       total: 1510
> 
> 
> Failed cases:
> Program/Build/vector-operators: fail
> Program/Execute/vector-arithmetic-int4: fail
> Program/Execute/scalar-logical-float: fail
> API/clCreateBuffer: fail
> 
> Skip cases:
> Program/Execute/Store/store-double-global: skip
> Program/Execute/Store/store-double2-local: skip
> Program/Execute/Store/store-double8-local: skip
> Program/Execute/Store/store-double4-global: skip
> Program/Execute/Store/store-double8-global: skip
> Program/Execute/program-tester-check-local-size-test-should-skip: skip
> Program/Execute/Store/store-double16-global: skip
> Program/Execute/Store/store-double2-global: skip
> Program/Execute/Store/store-double-local: skip
> Program/Execute/Store/store-double4-local: skip
> Program/Execute/Store/store-double16-local: skip
> 
> commit e8d27b8fda55376e7593a71ce53cbbf2b81e337a
> Author:     Ruiling Song <ruiling.song at intel.com<mailto:ruiling.song at intel.com>>
> AuthorDate: Fri Nov 29 16:03:42 2013 +0800
> Commit:     Zhigang Gong <zhigang.gong at intel.com<mailto:zhigang.gong at intel.com>>
> CommitDate: Thu Dec 5 13:56:38 2013 +0800
> 
>     GBE: improve asin/acos precision
> 
>     Signed-off-by: Ruiling Song <ruiling.song at intel.com<mailto:ruiling.song at intel.com>>
>     Tested-by: Zhigang Gong <zhigang.gong at linux.intel.com<mailto:zhigang.gong at linux.intel.com>>
> 
> 
> Thanks
>   --Sun, Yi
> 

> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet