[Beignet] [PATCH] Revert choose local size change when local size is null in clEnqueueNDRang.

Zhigang Gong zhigang.gong at linux.intel.com
Mon Dec 30 19:43:43 PST 2013


LGTM, pushed, thanks.

On Tue, Dec 24, 2013 at 01:40:16PM +0800, Yang Rong wrote:
> It will trigger some bugs if local size not 1, will re-enable it after fix these bugs.
> 
> Signed-off-by: Yang Rong <rong.r.yang at intel.com>
> ---
>  src/cl_api.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/cl_api.c b/src/cl_api.c
> index 1f720c7..405a41a 100644
> --- a/src/cl_api.c
> +++ b/src/cl_api.c
> @@ -2422,7 +2422,7 @@ clEnqueueNDRangeKernel(cl_command_queue  command_queue,
>    size_t fixed_global_sz[] = {1,1,1};
>    size_t fixed_local_sz[] = {1,1,1};
>    cl_int err = CL_SUCCESS;
> -  cl_uint i, j;
> +  cl_uint i;
>    enqueue_data *data, no_wait_data = { 0 };
>  
>    CHECK_QUEUE(command_queue);
> @@ -2472,13 +2472,13 @@ clEnqueueNDRangeKernel(cl_command_queue  command_queue,
>    if (local_work_size != NULL) {
>      for (i = 0; i < work_dim; ++i)
>        fixed_local_sz[i] = local_work_size[i];
> -  } else {
> +  } /*else {
>      for (i = 0; i< work_dim; i++)
>        for (j = 64; j > 1; j--) {   //check from 64?
>          if (global_work_size[i] % j == 0) //global_work_size always non null
>            fixed_local_sz[i] = j;
>        }
> -  }
> +  } */
>    if (global_work_size != NULL)
>      for (i = 0; i < work_dim; ++i)
>        fixed_global_sz[i] = global_work_size[i];
> -- 
> 1.8.1.2
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list