[Beignet] [PATCH] Adaptions for LLVM 3.3 / SPIR

[Dag Lem]

Zhigang Gong <zhigang.gong at linux.intel.com> writes:

> And one minor comment below:

[...]

>> +// FIXME:
>> +// This is a transitional hack to bypass the LLVM 3.3 built-in types.
>> +// See the Khronos SPIR specification for handling of these types.
> Should not define the image address space again for 3.2/3.1.
>
> #if 100 * __clang_major__ + __clang_minor__ == 303
>> +#define __texture __attribute__((address_space(4)))
> #endif

AFAIK it is legal to redefine a macro to the same definition. Does this
cause any problems in the form of warnings or otherwise? As noted it is
(hopefully) just a temporary hack for LLVM 3.3. I saw you mention that
you're going to work on this - great!

In any case, feel free to change this to your liking. I haven't got
access to my local git repository right now, so if you want me to change
this it will have to wait a day or two.

-- 
Best regards,

Dag Lem