[Beignet] clEnqueueNDRangeKernel and kernel completion

Zhigang Gong zhigang.gong at linux.intel.com
Wed Jun 12 23:36:11 PDT 2013


On Thu, Jun 13, 2013 at 06:04:59AM +0000, Zou, Nanhai wrote:
> 
> >> Which method do you prefer?
>  
> Should remove the following
> If (batch->buffer != NULL) {
> 	dri_bo_unreference(batch->buffer);
> 	batch->buffer = NULL);
> }
> That code is duplicated.
Ok, got it. Then we also need to remove the dri_bo_unreference in
intel_batchbuffer_delete(), right. As it is duplicate too, the buffer
is already unreferenced at intel_batchbuffer_terminate(). Right?

> 
> And 
> dri_bo_unreference looks more consistant.
> 
> Thanks
> Zou Nanhai
> 
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list