[Beignet] [PATCH 3/7] disable buggy old code doing global constant

[Xing, Homer]

OK. I'll send another patch to remove all of the code including the HACK:!!!.

-----Original Message-----
From: beignet-bounces+homer.xing=intel.com at lists.freedesktop.org [mailto:beignet-bounces+homer.xing=intel.com at lists.freedesktop.org] On Behalf Of Zhigang Gong
Sent: Saturday, April 27, 2013 6:38 PM
To: Xing, Homer
Cc: beignet at lists.freedesktop.org
Subject: Re: [Beignet] [PATCH 3/7] disable buggy old code doing global constant


LGTM. Could you also add some explaintation here? and I think the former_version seems useless after you implement the constant support, you may consider to remove all of the code including the HACK:!!!.

On Thu, Apr 25, 2013 at 02:21:25PM +0800, Homer Hsing wrote:
> 
> Signed-off-by: Homer Hsing <homer.xing at intel.com>
> ---
>  backend/src/llvm/llvm_passes.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/backend/src/llvm/llvm_passes.cpp 
> b/backend/src/llvm/llvm_passes.cpp
> index b38ef58..2811420 100644
> --- a/backend/src/llvm/llvm_passes.cpp
> +++ b/backend/src/llvm/llvm_passes.cpp
> @@ -230,7 +230,7 @@ namespace gbe
>  
>      if(isa<GlobalVariable>(parentPointer)) //HACK: !!!!
>      {
> -#if 1//FORMER_VERSION
> +#if FORMER_VERSION
>        Function *constWrapper = 
>          Function::Create(FunctionType::get(parentPointer->getType(),true),
>              GlobalValue::ExternalLinkage,
> --
> 1.8.1.2
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet