[Beignet] [PATCH 6/7] Support global constant arrays

[Xing, Homer]

By the way, I've just sent the new version of seven patches. The new version is version three, not version two, because the first patch has been updated twice :)

-----Original Message-----
From: beignet-bounces+homer.xing=intel.com at lists.freedesktop.org [mailto:beignet-bounces+homer.xing=intel.com at lists.freedesktop.org] On Behalf Of Xing, Homer
Sent: Thursday, May 02, 2013 8:38 AM
To: beignet at lists.freedesktop.org
Subject: Re: [Beignet] [PATCH 6/7] Support global constant arrays

Yes, I think so. Will send version two of this patch.

> Only one comment here, if the con.getOffset() is zero, then we can save one instruction.
> And furthermore, if the offset is zero, can we just set the reg as ir::ocl::constoffst's proxy register, then we can save two instructions here? I'm not very sure of this. But at least, you can save at least one instruction if the offset is zero. For all the rest of the patch, LGTM. Thanks for the patch.

_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet