[Beignet] [PATCH] Generate all supported as_* functions

[zhigang gong]

Maybe you could take a look at what we did on ocl_common_defines.h. That's
an example of separate header file for open cl kernels.
Need to add something to the CMake script file to stringfy it to a .cpp and
build it into the library, and need to modify function
programNewFromSource() to include it when build OCL source file.


On Fri, May 17, 2013 at 10:53 PM, Simon Richter <Simon.Richter at hogyros.de>wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> On 17.05.2013 06:05, Zhigang Gong wrote:
>
> > Nice work. One comment,  as the ocl_stdlib.h is already too large,
> > and this patch almost double its size. Could you consider to put
> > the generated part in a separated header file?
>
> Not easily, as the entire text will have to end up as a single string,
> so either I add a preprocessing layer or do the substitution in-place.
>
> I'm taking a look at whether the compiler invocation can be improved here.
>
>    Simon
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iJwEAQECAAYFAlGWRGgACgkQ0sfeulffv7skDAQAkIyhnEBrueQk82Aa/ssULR1Q
> DaHeoC5RLhOyTc6zTCvRSoFHvjpK3SgJmq3lwTKtVAh8o+Dc4jCTd80/hJ9t0hxC
> YGjsNMECYaHkLLEu9TEEjTfPyuZhdnQ29h1IOjaTu13YCGVC/ba+VbTG90AfdwBJ
> cWvCrHNwp7/cec+BsUI=
> =f/YN
> -----END PGP SIGNATURE-----
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20130517/78c716dd/attachment-0001.html>