[Beignet] [PATCH] Implement clEnqueueReadImage and clEnqueueWriteImage.

[Dag Lem]

Zhigang Gong <zhigang.gong at linux.intel.com> writes:

> In general, this patch looks good to me. Could you split it to two patches?
> One is for clEnqueueReadImage/WriteImage. And the other is to refine the
> clEnqueueMapImage. And you may consider to merge the clEnqueueMapImage refinement
> patch and the previous's clEnqueueMapImage patch.
>

OK, I'm working on it.

> Another issue about the clEnqueueMapImage is that if the image is a tiled
> buffer, then we may need to use clMapBufferGTTIntel to map it to vma. Otherwise,
> we may get a tiled mapping address which is not expected by user.

OK, so I should use clMapBufferIntel if cl_mem.tiled == CL_NO_TILE,
clMapBufferGTTIntel if cl_mem.tiled == CL_TILE_Y, and throw an error
otherwise (i.e. for the currently unused CL_TILE_X)?

I guess clEnqueueUnmapMemObject should also be changed to call
clUnmapBufferGTTIntel for tiled images?

-- 
Best regards,

Dag Lem