[Beignet] [PATCH 1/3] GBE: Remove max_limit for struct alignment

Sun, Yi yi.sun at intel.com
Mon Nov 11 00:57:31 PST 2013


This patch cause scalar-data-type-half	failed.
./piglit-run.py -t scalar-data-type-half tests/all_cl.tests t

Thanks
  --Sun, Yi

> -----Original Message-----
> From: beignet-bounces at lists.freedesktop.org
> [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Ruiling Song
> Sent: Friday, November 8, 2013 2:20 PM
> To: beignet at lists.freedesktop.org
> Cc: Song, Ruiling
> Subject: [Beignet] [PATCH 1/3] GBE: Remove max_limit for struct alignment
> 
> a struct may have vector field (like int8/16), max_limit is meaningless.
> 
> Signed-off-by: Ruiling Song <ruiling.song at intel.com>
> ---
>  backend/src/llvm/llvm_passes.cpp |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/backend/src/llvm/llvm_passes.cpp
> b/backend/src/llvm/llvm_passes.cpp
> index 60c9df1..6097f80 100644
> --- a/backend/src/llvm/llvm_passes.cpp
> +++ b/backend/src/llvm/llvm_passes.cpp
> @@ -128,8 +128,6 @@ namespace gbe
> 
>    uint32_t getAlignmentByte(const ir::Unit &unit, Type* Ty)
>    {
> -    const uint32_t MAX_ALIGN = 8; //maximum size is 8 for doubles
> -
>      switch (Ty->getTypeID()) {
>        case Type::VoidTyID: NOT_SUPPORTED;
>        case Type::VectorTyID:
> @@ -153,8 +151,6 @@ namespace gbe
>          for(uint32_t subtype = 0; subtype < StrTy->getNumElements();
> subtype++)
>          {
>            maxa = std::max(getAlignmentByte(unit,
> StrTy->getElementType(subtype)), maxa);
> -          if(maxa==MAX_ALIGN)
> -            return maxa;
>          }
>          return maxa;
>        }
> --
> 1.7.9.5
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list