[Beignet] [PATCH 1/3] GBE: Fix null register to integer type

Xing, Homer homer.xing at intel.com
Tue Nov 19 21:54:45 PST 2013


Good patches. These patches look good to me.

-----Original Message-----
From: beignet-bounces at lists.freedesktop.org [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Ruiling Song
Sent: Wednesday, November 20, 2013 1:52 PM
To: beignet at lists.freedesktop.org
Cc: Song, Ruiling
Subject: [Beignet] [PATCH 1/3] GBE: Fix null register to integer type

GEN 'mach' instruction only support integer type register.

Signed-off-by: Ruiling Song <ruiling.song at intel.com>
---
 backend/src/backend/gen_context.cpp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend/src/backend/gen_context.cpp b/backend/src/backend/gen_context.cpp
index 43b3bc7..bbfc85d 100644
--- a/backend/src/backend/gen_context.cpp
+++ b/backend/src/backend/gen_context.cpp
@@ -1181,8 +1181,8 @@ namespace gbe
     loadBottomHalf(d, y);
     p->push();
     p->curr.predicate = GEN_PREDICATE_NONE;
-    I32FullMult(GenRegister::null(), e, b, c);
-    I32FullMult(GenRegister::null(), f, a, d);
+    I32FullMult(GenRegister::retype(GenRegister::null(), GEN_TYPE_D), e, b, c);
+    I32FullMult(GenRegister::retype(GenRegister::null(), GEN_TYPE_D), f, a, d);
     p->ADD(e, e, f);
     I32FullMult(f, a, b, d);
     p->ADD(e, e, f);
-- 
1.7.9.5

_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list