[Beignet] [PATCH] GBE: Fix a bo->offset assert

He Junyan junyan.he at inbox.com
Mon Oct 21 21:36:16 PDT 2013


Reviewed, very thanks for fixing this bug.

On Tue, 2013-10-22 at 12:02 +0800, Ruiling Song wrote:
> scratchSize was missed in the binary, which will cause a random value
> when kernel is loaded from binary. add it in the binary format.
> 
> Signed-off-by: Ruiling Song <ruiling.song at intel.com>
> ---
>  backend/src/backend/program.cpp |    3 +++
>  backend/src/backend/program.hpp |    2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/backend/src/backend/program.cpp b/backend/src/backend/program.cpp
> index b2879a4..b9925d6 100644
> --- a/backend/src/backend/program.cpp
> +++ b/backend/src/backend/program.cpp
> @@ -244,6 +244,7 @@ namespace gbe {
>      OUT_UPDATE_SZ(curbeSize);
>      OUT_UPDATE_SZ(simdWidth);
>      OUT_UPDATE_SZ(stackSize);
> +    OUT_UPDATE_SZ(scratchSize);
>      OUT_UPDATE_SZ(useSLM);
>      OUT_UPDATE_SZ(slmSize);
>  
> @@ -332,6 +333,7 @@ namespace gbe {
>      IN_UPDATE_SZ(curbeSize);
>      IN_UPDATE_SZ(simdWidth);
>      IN_UPDATE_SZ(stackSize);
> +    IN_UPDATE_SZ(scratchSize);
>      IN_UPDATE_SZ(useSLM);
>      IN_UPDATE_SZ(slmSize);
>  
> @@ -408,6 +410,7 @@ namespace gbe {
>      outs << spaces_nl << "  curbeSize: " << curbeSize << "\n";
>      outs << spaces_nl << "  simdWidth: " << simdWidth << "\n";
>      outs << spaces_nl << "  stackSize: " << stackSize << "\n";
> +    outs << spaces_nl << "  scratchSize: " << scratchSize << "\n";
>      outs << spaces_nl << "  useSLM: " << useSLM << "\n";
>      outs << spaces_nl << "  slmSize: " << slmSize << "\n";
>  
> diff --git a/backend/src/backend/program.hpp b/backend/src/backend/program.hpp
> index 895cd01..9b33b7c 100644
> --- a/backend/src/backend/program.hpp
> +++ b/backend/src/backend/program.hpp
> @@ -147,7 +147,9 @@ namespace gbe {
>         curbeSize         |
>         simdWidth         |
>         stackSize         |
> +       scratchSize       |
>         useSLM            |
> +       slmSize           |
>         samplers          |
>         images            |
>         code_size         |





More information about the Beignet mailing list