[Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

Yang, Rong R rong.r.yang at intel.com
Tue Oct 29 08:44:25 CET 2013


LGTM, thanks.

-----Original Message-----
From: beignet-bounces at lists.freedesktop.org [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Zhigang Gong
Sent: Tuesday, October 29, 2013 3:07 PM
To: beignet at lists.freedesktop.org
Cc: Zhigang Gong
Subject: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

For most vector relational builtin functions, we need to return -1 if the element result is true, return 0 if the element result is 0. So we can simply put a - in front of the scalar version of function for each element.

Reported by Yang Rong.

Signed-off-by: Zhigang Gong <zhigang.gong at linux.intel.com>
---
 backend/src/gen_builtin_vector.py |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/backend/src/gen_builtin_vector.py b/backend/src/gen_builtin_vector.py
index 0a30738..d7336af 100755
--- a/backend/src/gen_builtin_vector.py
+++ b/backend/src/gen_builtin_vector.py
@@ -293,6 +293,8 @@ class builtinProto():
                 if j % 2 == 0:
                     formatStr = self.append(formatStr, self.indentSpace())
 
+            if self.prefix == 'relational' and self.functionName != 'bitselect' and self.functionName != 'select':
+                formatStr += '-'
             formatStr += '{}('.format(self.functionName)
             for n in range(0, self.paramCount):
                 if n != 0:
--
1.7.9.5

_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list