[Beignet] [regression] Piglit/Bitcoin fail

[Sun, Yi]

Yep, after a quick testing with patch "GBE: Support composite type constant", I verified the patch can fix this issue.

Thanks
  --Sun, Yi

From: Song, Ruiling
Sent: Wednesday, September 18, 2013 10:21 AM
To: Song, Ruiling; Sun, Yi; Gong, Zhigang
Cc: beignet at lists.freedesktop.org
Subject: RE: [Beignet] [regression] Piglit/Bitcoin fail

Hi Yi,

The problem comes from below line:
int type_size = pointer->getType()->getPrimitiveSizeInBits() / 8;
here the getType will get a ArrayType * which is not primitive type.
I should getElementType() to get the primitive type in the array before getPrimitiveSizeInBits()
AS it is already fixed in new patch "GBE-Support-composite-type-constant.patch", so I will not send a separate patch for the fix.
I also change the unit test compiler_global_constant to "constant int o[3]= {3, 2, 1};" to detect the issue.

Great thanks!

Ruiling
From: beignet-bounces+ruiling.song=intel.com at lists.freedesktop.org<mailto:beignet-bounces+ruiling.song=intel.com at lists.freedesktop.org> [mailto:beignet-bounces+ruiling.song=intel.com at lists.freedesktop.org] On Behalf Of Song, Ruiling
Sent: Wednesday, September 18, 2013 9:14 AM
To: Sun, Yi; Gong, Zhigang
Cc: beignet at lists.freedesktop.org<mailto:beignet at lists.freedesktop.org>
Subject: Re: [Beignet] [regression] Piglit/Bitcoin fail

Thanks Yi,

I will look at this issue.

From: Sun, Yi
Sent: Tuesday, September 17, 2013 5:49 PM
To: Gong, Zhigang; Song, Ruiling
Cc: beignet at lists.freedesktop.org<mailto:beignet at lists.freedesktop.org>
Subject: [Beignet][regression] Piglit/Bitcoin fail

Following commit causes Piglit/Bitcoin fail.

Cmd: piglit-run.py -t Bitcoin tests/all_cl.test result

commit fd98654b20589eb942fe834fd735431a46f17b0e
Author:     Ruiling Song <ruiling.song at intel.com<mailto:ruiling.song at intel.com>>
AuthorDate: Wed Sep 11 15:22:03 2013 +0800
Commit:     Zhigang Gong <zhigang.gong at linux.intel.com<mailto:zhigang.gong at linux.intel.com>>
CommitDate: Tue Sep 17 16:23:08 2013 +0800

    Fix non-4byte program global constant issue.

    We put array elements simply one after another, that is packed.
    So, constant memory address should be calculated using real type size.

    Signed-off-by: Ruiling Song <ruiling.song at intel.com<mailto:ruiling.song at intel.com>>
Reviewed-by: Zhigang Gong zhigang.gong at linux.intel.com<mailto:zhigang.gong at linux.intel.com>

Thanks
  --Sun, Yi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20130918/59a126a8/attachment.html>