[Beignet] [PATCH 3/3] GBE: work around baytrail-t hang issue.

[Zhigang Gong]

On Fri, Apr 18, 2014 at 11:08 AM, Zhenyu Wang <zhenyuw at linux.intel.com>wrote:

> On 2014.04.17 15:06:10 +0800, Chuanbo Weng wrote:
> >    {
> > -    const GenMessageTarget sfid = GEN6_SFID_DATAPORT_CONSTANT_CACHE;
> > +    // FIXME there is a unknown issue with baytrail-t platform, the
> DWORD scatter
> > +    // message causes a hang at unit test case compiler_global_constant.
> > +    // We workaround it to use DATA CACHE instead.
> > +    const GenMessageTarget sfid = (p->deviceID == PCI_CHIP_BAYTRAIL_T) ?
> > +                                 GEN_SFID_DATAPORT_DATA_CACHE :
> GEN6_SFID_DATAPORT_CONSTANT_CACHE;
>
> Use IS_BAYTRAIL_T() will be better as there're several VLV devices
> I believe you will add later, you may check kernel or other driver.
> Consider our devices have more variants in recent generations, using
> kind of macro flag for them is always better.
>
 Good suggestion. But I'm not very sure whether all the baytrial variants
have this same issue.
 I will choose to leave it as is currently. If I get chance to test it on
the baytrail variants I
 will change it to use a macro to include all the affected device IDs in
one macro. Any comments?


> --
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
>
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20140418/aadeb6a0/attachment.html>