[Beignet] [PATCH] GBE: switch to use CLANG native image types.

[Yang, Rong R]

OK, no other comment.

> -----Original Message-----
> From: Zhigang Gong [mailto:zhigang.gong at linux.intel.com]
> Sent: Thursday, December 18, 2014 15:17
> To: Yang, Rong R
> Cc: Gong, Zhigang; beignet at lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH] GBE: switch to use CLANG native image types.
> 
> On Thu, Dec 18, 2014 at 03:00:38PM +0800, Zhigang Gong wrote:
> > On Thu, Dec 18, 2014 at 07:41:55AM +0000, Yang, Rong R wrote:
> > > One minor comment.
> > >
> >
> > > > +        if (llvmInfo.isImageType()) {
> > > > +          ctx.input(argName, ir::FunctionArgument::IMAGE, reg,
> > > > + llvmInfo, 4, 4,
> > > > 0);
> > > [Yang, Rong R] Is it safe to hard code the size to 4?
> >
> > It is safe if we haven't switch to 64 bit pointer. But it's not good
> > to hard coded it to 4. I will change it to use pointersize rather than 4.
> 
> Oh, talk too fast, this is image not buffer object, and we will never access it
> via a pointer. So it's indeed always safe even we switch to 64 bit pointer in
> the future. What's further comment?
> 
> >
> > Thanks for the comment.
> >
> > >
> > >
> > _______________________________________________
> > Beignet mailing list
> > Beignet at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/beignet