[Beignet] [PATCH 0/2] support ICD by default

Zhigang Gong zhigang.gong at intel.com
Wed Jan 8 03:31:07 PST 2014


This patchset is to support ICD by default. Then the developer could use beignet
easier when the developer want to start with beignet source code directly.

So we made two changes, the first is to back port the ICD support to the 1.1 branch.
The second is to change the build script to generate proper ICD vendor file and install
the library/vendor file to correct directory. To make things simpler, this patch
change the libgbe to a static library and don't install it to the system.

Now the user just need to install the following two packages:
ocl-icd-dev, ocl-icd-libopencl1.
Then download beignet source code tree, and build/install beignet. Then user could
use beignet library through the standard ICD interface libOpenCL.so.

If just want to play beignet with beignet source code, then we are fine now.
But from a package maintainer's view, there is one major remained issue 
which is the PCH file's dependency. I just found that when build
user kernel with the pch option, the clang need to check the header files which is
used to generate the pch file. We currently don't install the header file, the even
worse fact is that the clang assumes that header file is still in the original
position and hasn't been touched.

It seems that we have to deffer the pch's generation to the final package installation
stage.

Simon & Junyan, do you have any comments here? Thanks.


Zhigang Gong (2):
  CL: back port ICD support to 1.1 branch.
  CL: prepare to support ICD by default.

 CMake/FindGBE.cmake           |   37 -------------------------------------
 CMakeLists.txt                |   16 +++++++---------
 backend/src/CMakeLists.txt    |   15 +++++++--------
 backend/src/ocl_stdlib.tmpl.h |    2 +-
 src/CMakeLists.txt            |    2 +-
 src/cl_khr_icd.c              |    9 ++++++++-
 6 files changed, 24 insertions(+), 57 deletions(-)
 delete mode 100644 CMake/FindGBE.cmake

-- 
1.7.9.5



More information about the Beignet mailing list