[Beignet] [PATCH] Handle server IVB GT2.

Zhigang Gong zhigang.gong at linux.intel.com
Sun Jun 8 22:10:42 PDT 2014


Thanks for the patch. This patch LGTM, but I just found that
the 0x016a is not in the script file GetGenID.sh.
If we want to add this new PCI ID, we should also add it in the
script file. Junyan, could you help to check the script file?
Thanks. I think that you get the current PCI ID list from the
kernel header file. Just wonder why 0x016a is missed.

On Fri, Jun 06, 2014 at 02:16:25PM -0400, Abrahm Scully wrote:
> ---
>  src/cl_device_data.h | 4 +++-
>  src/cl_device_id.c   | 2 ++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/cl_device_data.h b/src/cl_device_data.h
> index 55327ec..c1e4e93 100644
> --- a/src/cl_device_data.h
> +++ b/src/cl_device_data.h
> @@ -67,6 +67,7 @@
>  #define PCI_CHIP_IVYBRIDGE_M_GT1        0x0156  /* Mobile */
>  #define PCI_CHIP_IVYBRIDGE_M_GT2        0x0166
>  #define PCI_CHIP_IVYBRIDGE_S_GT1        0x015a  /* Server */
> +#define PCI_CHIP_IVYBRIDGE_S_GT2        0x016a
>  
>  #define PCI_CHIP_BAYTRAIL_T 0x0F31
>  
> @@ -77,7 +78,8 @@
>  
>  #define IS_IVB_GT2(devid)               \
>    (devid == PCI_CHIP_IVYBRIDGE_GT2 ||   \
> -   devid == PCI_CHIP_IVYBRIDGE_M_GT2)
> +   devid == PCI_CHIP_IVYBRIDGE_M_GT2 || \
> +   devid == PCI_CHIP_IVYBRIDGE_S_GT2)
>  
>  #define IS_BAYTRAIL_T(devid)              \
>    (devid == PCI_CHIP_BAYTRAIL_T)
> diff --git a/src/cl_device_id.c b/src/cl_device_id.c
> index d2b3bed..5d31ec3 100644
> --- a/src/cl_device_id.c
> +++ b/src/cl_device_id.c
> @@ -221,6 +221,8 @@ ivb_gt1_break:
>        DECL_INFO_STRING(ivb_gt2_break, intel_ivb_gt2_device, name, "Intel(R) HD Graphics IvyBridge GT2");
>      case PCI_CHIP_IVYBRIDGE_M_GT2:
>        DECL_INFO_STRING(ivb_gt2_break, intel_ivb_gt2_device, name, "Intel(R) HD Graphics IvyBridge M GT2");
> +    case PCI_CHIP_IVYBRIDGE_S_GT2:
> +      DECL_INFO_STRING(ivb_gt2_break, intel_ivb_gt2_device, name, "Intel(R) HD Graphics IvyBridge S GT2");
>  ivb_gt2_break:
>        intel_ivb_gt2_device.vendor_id = device_id;
>        intel_ivb_gt2_device.platform = intel_platform;
> -- 
> 1.9.3
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list