[Beignet] [V2 PATCH 1/6] Update the device info description for HSW

[He Junyan]

OK, name modified and new patch sent

On Thu, 2014-05-08 at 07:43 -0400, Jesper Pedersen wrote:
> Hi,
> 
> On 05/07/2014 06:02 AM, junyan.he at inbox.com wrote:
> > From: Junyan He <junyan.he at linux.intel.com>
> >
> > Split the cl_device_id description for HSW into
> > GT1, GT2 and GT3, with different parameters.
> >
> > Signed-off-by: Junyan He <junyan.he at linux.intel.com>
> > ---
> >   src/cl_device_id.c | 135 +++++++++++++++++++++++++++++++++++------------------
> >   1 file changed, 90 insertions(+), 45 deletions(-)
> >
> >   #define DECL_INFO_STRING(BREAK, STRUCT, FIELD, STRING) \
> >       STRUCT.FIELD = STRING; \
> >       STRUCT.JOIN(FIELD,_sz) = sizeof(STRING); \
> > +    hsw_device = &STRUCT; \
> >       goto BREAK;
> >
> 
> Can't this be moved to the actual Haswell block ?
> 
> It doesn't really make sense to assign it for all non-Haswell devices.
> 
> >   has_break:
> > -      intel_hsw_device.vendor_id = device_id;
> > -      intel_hsw_device.platform = intel_platform;
> > -      ret = &intel_hsw_device;
> > +      hsw_device->vendor_id = device_id;
> > +      hsw_device->platform = intel_platform;
> > +      ret = hsw_device;
> >         break;
> >
> 
> E.g. down here.
> 
> Best regards,
>   Jesper
> 
> 
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet