[Beignet] [PATCH 3/4] GBE: fix disassembly bug.

Zhigang Gong zhigang.gong at linux.intel.com
Tue Nov 4 02:49:17 PST 2014


Right, I already fixed it locally, just forgot to commit.
Will push my local version.
Thanks for the review comments.

On Tue, Nov 04, 2014 at 09:00:04AM +0000, Yang, Rong R wrote:
> This patch will cause some unused-variable warning.
> 
> > -----Original Message-----
> > From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> > Zhigang Gong
> > Sent: Monday, November 3, 2014 16:25
> > To: beignet at lists.freedesktop.org
> > Cc: Gong, Zhigang
> > Subject: [Beignet] [PATCH 3/4] GBE: fix disassembly bug.
> > 
> > Those math attributes are not valid on Gen7/7.5.
> > 
> > Signed-off-by: Zhigang Gong <zhigang.gong at intel.com>
> > ---
> >  backend/src/backend/gen/gen_mesa_disasm.c | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/backend/src/backend/gen/gen_mesa_disasm.c
> > b/backend/src/backend/gen/gen_mesa_disasm.c
> > index 876bbeb..872d4e6 100644
> > --- a/backend/src/backend/gen/gen_mesa_disasm.c
> > +++ b/backend/src/backend/gen/gen_mesa_disasm.c
> > @@ -1187,14 +1187,6 @@ int gen_disasm (FILE *file, const void *inst,
> > uint32_t deviceID, uint32_t compac
> >                       MATH_FUNCTION(inst), &space);
> >      }
> > 
> > -    err |= control(file, "math saturate", math_saturate,
> > -                   MATH_SATURATE(inst), &space);
> > -    err |= control(file, "math signed", math_signed,
> > -                   MATH_SIGNED(inst), &space);
> > -    err |= control(file, "math scalar", math_scalar,
> > -                   MATH_SCALAR(inst), &space);
> > -    err |= control(file, "math precision", math_precision,
> > -                   MATH_PRECISION(inst), &space);
> >    } else if (OPCODE(inst) != GEN_OPCODE_SEND &&
> >               OPCODE(inst) != GEN_OPCODE_SENDC) {
> >      err |= control(file, "conditional modifier", conditional_modifier,
> > --
> > 1.8.3.2
> > 
> > _______________________________________________
> > Beignet mailing list
> > Beignet at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/beignet
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list