[Beignet] [PATCH] GBE: remove useless debug info.

Song, Ruiling ruiling.song at intel.com
Wed Nov 5 22:10:31 PST 2014


LGTM

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Zhigang Gong
> Sent: Monday, November 03, 2014 4:28 PM
> To: beignet at lists.freedesktop.org
> Cc: Gong, Zhigang
> Subject: [Beignet] [PATCH] GBE: remove useless debug info.
> 
> This debug information is not useful now. Remove them to avoid confusing.
> 
> Signed-off-by: Zhigang Gong <zhigang.gong at intel.com>
> ---
>  backend/src/backend/gen_insn_selection.cpp | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/backend/src/backend/gen_insn_selection.cpp
> b/backend/src/backend/gen_insn_selection.cpp
> index 64e9fd8..a9ef818 100644
> --- a/backend/src/backend/gen_insn_selection.cpp
> +++ b/backend/src/backend/gen_insn_selection.cpp
> @@ -802,13 +802,8 @@ namespace gbe
>            }
>          }
> 
> -        if (poolOffset > ctx.reservedSpillRegs) {
> -          if (GBE_DEBUG)
> -            std::cerr << "Instruction (#" << (uint32_t)insn.opcode
> -                      << ") src too large pooloffset "
> -                      << (uint32_t)poolOffset << std::endl;
> +        if (poolOffset > ctx.reservedSpillRegs)
>            return false;
> -        }
>          // FIXME, to support post register allocation scheduling,
>          // put all the reserved register to the spill/unspill's destination
> registers.
>          // This is not the best way. We need to refine the spill/unspill
> instruction to @@ -872,13 +867,8 @@ namespace gbe
>            }
>          }
> 
> -        if (poolOffset > ctx.reservedSpillRegs){
> -          if (GBE_DEBUG)
> -           std::cerr << "Instruction (#" << (uint32_t)insn.opcode
> -                     << ") dst too large pooloffset "
> -                     << (uint32_t)poolOffset << std::endl;
> +        if (poolOffset > ctx.reservedSpillRegs)
>            return false;
> -        }
>          while(!regSet.empty()) {
>            struct RegSlot regSlot = regSet.back();
>            regSet.pop_back();
> --
> 1.8.3.2
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list