[Beignet] Can Beignet be used with OpenCLIPP?

[Zhigang Gong]

Geoffroy,

I tried OpenCLIPP. After some fixes in OpenCLIPP part, it works well with beignet.

gongzg at ivb-gt2-rev4:~/git/fdo/OpenCLIPP-master/Test-OpenCLIPP$ LD_LIBRARY_PATH=`pwd`/.. ./Test-OpenCLIPP
Using OpenCL device : Intel(R) HD Graphics IvyBridge GT2
Success

And all the benchmark could finish successfully. 

It seems that the OpenCLIPP is mainly for windows platform, part of the fix is to
fix those obvious broken directories name on linux platform, such as:
diff -ur OpenCLIPP-master/Bench/src/config.h ../OpenCLIPP-master/Bench/src/config.h
--- OpenCLIPP-master/Bench/src/config.h 2014-10-18 02:22:09.000000000 +0800
+++ ../OpenCLIPP-master/Bench/src/config.h  2014-11-08 08:18:58.928449952 +0800
@@ -33,7 +33,7 @@

 // Full path to the .cl files for OpenCLIPP
 // Must not contain spaces if using the NVIDIA platform
-#define CL_FILES_PATH      "D:/OpenCLIPP/cl-files/"
+#define CL_FILES_PATH      "/home/gongzg/test/OpenCLIPP-master/cl-files"

Another major fix is like below. Per opencl spec, constant buffer could only be declared in a function. It could only be declared in program
scope.

--- OpenCLIPP-master/cl-files/Filters.cl    2014-10-18 02:22:09.000000000 +0800
+++ ../OpenCLIPP-master/cl-files/Filters.cl 2014-11-08 09:13:15.768519180 +0800
@@ -152,264 +152,260 @@
    WRITE(dest, sum);
 }

-kernel void gaussian3(INPUT source, OUTPUT dest DIM_ARGS)
-{
-   CONST float matrix[9] = {
+   CONST float gaussian3_matrix[9] = {
       1.f/16, 2.f/16, 1.f/16,
       2.f/16, 4.f/16, 2.f/16,
       1.f/16, 2.f/16, 1.f/16};
+kernel void gaussian3(INPUT source, OUTPUT dest DIM_ARGS)
+{

-   convolution(source, dest DIMS, matrix, 3);
+   convolution(source, dest DIMS, gaussian3_matrix, 3);
 }


If you want to get the whole patch for OpenCLIPP, please let me know.

Thanks,
Zhigang Gong.

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> VanCutsem, Geoffroy
> Sent: Saturday, November 8, 2014 1:31 AM
> To: beignet at lists.freedesktop.org
> Subject: [Beignet] Can Beignet be used with OpenCLIPP?
> 
> Hi folks,
> 
> I'm wondering if anyone has ever tried to use Beignet as the OpenCL SDK for
> OpenCLIPP (http://openclipp.wix.com/openclipp). Looking at their website,
> they have validated they can use an OpenCL SDK from Intel but it only uses the
> CPU (no GPU).
> 
> Thanks,
> Geoffroy
> 
> -----------------------------------------------
> Intel Corporation NV/SA
> Kings Square, Veldkant 31
> 2550 Kontich
> RPM (Bruxelles) 0415.497.718.
> Citibank, Brussels, account 570/1031255/09
> 
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet