[Beignet] Problems with recent beignet

[He Junyan]

Yes, we have found this problem.
New version beignet requires libdrm at least 2.4.52
Old version of libdrm will cause the build fail.
We have already add the libdrm version check

On 四, 2014-10-16 at 21:53 -0700, Andi Kleen wrote:
> I tried the current beignet master on my OpenSUSE 13.1 HSW and 
> ran into the following new problems (older versions worked):
> 
> - With my DRM version I have the build always fails with:
> 
> src/intel/intel_gpgpu.c: In function
> ‘intel_gpgpu_setup_bti_gen8’:
> src/intel/intel_gpgpu.c:922:39: error:
> ‘drm_intel_bo’ has no member named ‘offset64’
>    ss0->ss8.surface_base_addr_lo = (buf->offset64 + internal_offset) &
>    0xffffffff;
>                                        ^
> src/intel/intel_gpgpu.c:923:40: error:
> ‘drm_intel_bo’ has no member named ‘offset64’
>    ss0->ss9.surface_base_addr_hi = ((buf->offset64 + internal_offset) >>
>    32) & 0xffffffff;
>                                         ^
> src//beignet/src/intel/intel_gpgpu.c: In function
> ‘intel_gpgpu_bind_image_gen8’:
> [ 25%] src/intel/intel_gpgpu.c:1112:40: error:
> ‘drm_intel_bo’ has no member named ‘offset64’
>    ss->ss8.surface_base_addr_lo = obj_bo->offset64 & 0xffffffff;
>                                         ^
> /home/ak/src/beignet/src/intel/intel_gpgpu.c:1113:41: error:
> ‘drm_intel_bo’ has no member named ‘offset64’
>    ss->ss9.surface_base_addr_hi = (obj_bo->offset64 >> 32) & 0xffffffff;
> 
> I just commented out these lines because they seem to be only used on GEN8.
> Probably would be good to have a cmake test that tests for these fields
> and disables gen8 or falls back to plain "offset" ?
> 
> - With that fixed the first utest always bails out with:
> 
> builtin_acos_float()utest_run:
> /home/ak/src/beignet/src/intel/intel_gpgpu.c:703:
> intel_gpgpu_check_binded_buf_address: Assertion
> `gpgpu->binded_buf[i]->offset != 0' failed.
>     Interrupt signal (SIGABRT) received.
> summary:
> ----------
>   total: 684
>   run: 1
>   pass: 0
>   fail: 1
> 
> 
> The assert mentions the same name as above, but I believe it's a different field.
> I tried to bisect that and ended up with the following commit. Not sure
> if that is correct? Unfortunately it doesn't cleanly revert from master
> for testing.
> 
> commit 8c1ed91f0af6ab8284fe06b4c582b55c7d925816
> Author: Zhigang Gong <zhigang.gong at intel.com>
> Date:   Fri Sep 12 13:45:40 2014 +0800
> 
>     GBE: fix multiple files compilation bugs.
>     
>     If we want to link multiple files together, and one kernel
>     function need refer other kernel functions in other files,
>     we must not set those functions as linked once attribute.
> 
> 
> -Andi
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet