[Beignet] [PATCH] OCL_BITCODE_BIN path missing "/"

[He Junyan]

OK, I have tried the issue you mentioned,
and it really causes some problems.
Thanks for your reporting and please
re-send a patch to include all the places you
have mentioned.


On 日, 2014-10-19 at 17:30 +0100, Steven Newbury wrote:
> On Sun, 2014-10-19 at 17:13 +0100, Steven Newbury wrote:
> > On Sun, 2014-10-19 at 16:29 +0100, Steven Newbury wrote:
> > > On Sun, 2014-10-19 at 11:18 -0400, Yichao Yu wrote:
> > > > On Sun, Oct 19, 2014 at 10:46 AM, Steven Newbury <
> > > > steve at snewbury.org.uk> wrote:
> > > > > The OCL_BITCODE_BIN path should contain a "/" after
> > > > > ${BEIGNET_INSTALL_DIR} in case the expanded path doesn't
> > > > > contain a trailing "/".
> > > > > 
> > > > > ---
> > > > > 
> > > > > --- backend/src/CMakeLists.txt~       2014-10-19
> > > > > 15:31:58.000000000 +0100
> > > > > +++ backend/src/CMakeLists.txt  2014-10-19 15:33:53.705853137
> > > > > +0100
> > > > > @@ -1,4 +1,4 @@
> > > > > -set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}beignet.bc")
> > > > > +set (OCL_BITCODE_BIN "${BEIGNET_INSTALL_DIR}/beignet.bc")
> > > > >  set (OCL_HEADER_DIR "${CMAKE_INSTALL_PREFIX}/include/CL/ocl/")
> > > > >  set (OCL_PCH_OBJECT "${BEIGNET_INSTALL_DIR}beignet.pch")
> > > > 
> > > > Maybe also here?
> > > > 
> > > Definitely also there!  How did I miss that?  I was looking for why
> > > beignet.bc wasn't being found at run-time, beignet.pch failure 
> > > wasn't
> > > fatal, so I didn't look at it.
> > > 
> > This is fun, fixing the pre-compiled header path breaks my build!
> > 
> Using the "-fpch-deps" gcc flag seems to have fixed it.
> 
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet