[Beignet] Beignet 0.9.2 compilation feedback

[Gong, Zhigang]

> -----Original Message-----
> From: Jérôme Carretero [mailto:cJ at zougloub.eu]
> Sent: Sunday, September 7, 2014 1:10 AM
> To: Gong, Zhigang
> Cc: beignet at lists.freedesktop.org
> Subject: Beignet 0.9.2 compilation feedback
> 
> Hi,
> 
> 
> This is my feedback for installing Beignet 0.9.2.
> Should be applicable to the latest commit also.
> 
> 1. Build failure because GBE_DEBUG was undefined.
>    It is not activated by the build system.
This is weird, as you can check in the backend/CMakeList.txt the GBE_DEBUG macro is defined
for all configurations GCC/CLANG/ICC and DEBUG/RELWITHDEBUGINFO/MINSIZEREL/RELEASE.
Don't know why you got such an issue?

> 
> 2. Tried to add -DGBE_DEBUG=0 to CXXFLAGS via a CMAKE defines override.
>    Didn't work... it turns out that CXXFLAGS are overridden by mistake in
>    the backend folder.
>    Here's a patch to fix that:
> 
>     perl -p -i -e 's/(CMAKE_C_CXX_FLAGS)
> (-DGBE_COMPILER_AVAILABLE=1)/$1 "$2 \${CMAKE_C_CXX_FLAGS}"/g'
> backend/CMakeFiles.txt

You are right. I just sent a patch to fix this bug. Thanks.

> 
> 3. The configuration step doesn't check that OpenCL 1.2 headers are present,
>    and build failures are not obvious to understand if using older OpenCL
> headers.

Right, this is another issue. We will put it in our TODO list. Thanks.

> 
> For info, the Gentoo installation recipe I wrote is here:
>  http://zougloub.eu/git/zougloub-overlay/plain/dev-libs/intel-beignet
> 
> 
> Thanks a lot for this software, I had been longing for a long time for a usable
> free OpenCL implementation.
> 
> 
> Best regards,
> 
> --
> Jérôme