[Beignet] [PATCH 7/7] backend: Turn on ASM dump.
Song, Ruiling
ruiling.song at intel.com
Wed Aug 12 23:49:16 PDT 2015
The patchset LGTM.
But still I have some comments. The patchset work for clBuildProgram().
But you don't handle clCompileProgram() and clLinkProgram(). You need to double-check whether this is needed.
If needed, you have to refine the dump-llvm logic into BuildModuleFromSource, so that build/compile both share the logic.
And the dump-asm logic will be also needed in genProgramBuildFromLLVM()
Thanks!
Ruiling
More information about the Beignet
mailing list