[Beignet] [PATCH] Make FindLLVM.cmake work with empty "system-libs"

[Yang, Rong R]

Yes, if everything is built from source, LLVM don't need static libraries.
The patch looks good to me, thanks for your contribute.
Could you post the  e-mail submission patch? Use git format-patch and git send-email.

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Steven Newbury
> Sent: Monday, December 21, 2015 16:29
> To: Yang, Rong R
> Cc: beignet at lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH] Make FindLLVM.cmake work with empty
> "system-libs"
> 
> Gentoo doesn't support static LLVM libraries at all. It has a policy of always
> linking projects dynamically against the system libraries wherever possible.
> There is no advantage to static linking when everything is built from source
> against the same system.  This just works, except if system-libs is empty, the
> REGEX fails with a syntax error.
> 
> On Mon Dec 21 02:53:51 2015 GMT, Yang, Rong R wrote:
> > Because beignet link with the LLVM static libraries, and system-libs is
> required by LLVM libraries.
> > If Gentoo wipe "system-libs", do you know LLVM how to find this libraries?
> >
> > > -----Original Message-----
> > > From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On
> > > Behalf Of Steven Newbury
> > > Sent: Thursday, December 17, 2015 7:33
> > > To: beignet at lists.freedesktop.org
> > > Subject: [Beignet] [PATCH] Make FindLLVM.cmake work with empty
> > > "system-libs"
> > >
> > > On Gentoo we sanitise and fix up llvm-config to work with shared
> > > libraries and to provide correct output for @world to build against.
> > >  (See https://bugs.gentoo.org/show_bug.cgi?id=565358) Part of this
> > > is we wipe "system-libs" since it's inappropriate to link to unnecessarily.
> > >
> > > This has revealed the FindLLVM.cmake included with Beignet fails
> > > when system-libs is empty.  Attached patch fixes this by checking
> > > for a result before calling REGEX.
> >
> 
> --
> Sent from my Jolla
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet