[Beignet] version 4 of libva buffer sharing patchset

[Guo, Yejun]

The patch LGTM, thanks.

From: Weng, Chuanbo
Sent: Monday, February 02, 2015 3:06 PM
To: Guo, Yejun; beignet at lists.freedesktop.org
Subject: RE: version 4 of libva buffer sharing patchset

Removed and updated the patchset.

From: Guo, Yejun
Sent: Monday, February 02, 2015 14:11
To: Weng, Chuanbo; beignet at lists.freedesktop.org<mailto:beignet at lists.freedesktop.org>
Subject: RE: version 4 of libva buffer sharing patchset

Looks fine except one comment:  OUTPUT_NV12_DEFAULT is not really used, we can just remove it.

From: Weng, Chuanbo
Sent: Thursday, January 29, 2015 11:33 AM
To: Guo, Yejun; beignet at lists.freedesktop.org<mailto:beignet at lists.freedesktop.org>
Subject: RE: version 4 of libva buffer sharing patchset

Hi Yejun,
                Thanks for your comments!
                I have updated patcheset according to your comments. (Accept the 1st
comment, I think we could add more option or code when more example are being
added to.)
                Please review it.

Thanks,
Chuanbo Weng

From: Guo, Yejun
Sent: Monday, January 26, 2015 13:58
To: Weng, Chuanbo; beignet at lists.freedesktop.org<mailto:beignet at lists.freedesktop.org>
Subject: RE: version 4 of libva buffer sharing patchset

Some comments:


-          The examples build is bound closely with libva, no libva no build examples. Any expectation that other examples without libva dependency will be added?

-          In file libva_buffer_sharing line2, shall we add year 2015?

-          The input/output file name is suffixed with '.nv12', but the  real format is I420 since the u plane and v plane are separated.  My opinion is to always use nv12 format.

-          In function upload_nv12_to_surface and store_surface_to_nv12

For the code "if (surface_image.format.fourcc == VA_FOURCC_NV12)", how about the test if the condition is not satisfied, maybe we need assert here.


From: Weng, Chuanbo
Sent: Friday, January 23, 2015 6:23 PM
To: beignet at lists.freedesktop.org<mailto:beignet at lists.freedesktop.org>; Guo, Yejun
Subject: version 4 of libva buffer sharing patchset

Hi all,
Please fetch the 4th version of patchset from github using the following command:
git clone https://github.com/Chuanbo-Weng/libva-buffer-sharing-patches.git
Or visit:
    https://github.com/Chuanbo-Weng/libva-buffer-sharing-patches

*****For reviewers****:
Because we add libva as submodule, so please run the following command in root
directory of beignet source code to fetch libva:
git submodule add git://anongit.freedesktop.org/libva examples/thirdparty/libva
git commit -a -m "Add libva as submodule for review"

Then apply patchset, build and run example as said in docs/howto/libva-buffer-sharing-howto.mdwn.


Thanks,
Chuanbo Weng


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20150202/9e6e8a60/attachment.html>