[Beignet] [PATCH 2/6] Add long type support for disasm.

Yang, Rong R rong.r.yang at intel.com
Mon Jan 5 16:51:57 PST 2015


The others of patchset LGTM.

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Yang, Rong R
> Sent: Tuesday, January 6, 2015 08:51
> To: junyan.he at inbox.com; beignet at lists.freedesktop.org
> Cc: Junyan He
> Subject: Re: [Beignet] [PATCH 2/6] Add long type support for disasm.
> 
> Also need add long/ulong imm print.
> 
> > -----Original Message-----
> > From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf
> > Of junyan.he at inbox.com
> > Sent: Wednesday, December 24, 2014 00:13
> > To: beignet at lists.freedesktop.org
> > Cc: Junyan He
> > Subject: [Beignet] [PATCH 2/6] Add long type support for disasm.
> >
> > From: Junyan He <junyan.he at linux.intel.com>
> >
> > Signed-off-by: Junyan He <junyan.he at linux.intel.com>
> > ---
> >  backend/src/backend/gen/gen_mesa_disasm.c |   13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/backend/src/backend/gen/gen_mesa_disasm.c
> > b/backend/src/backend/gen/gen_mesa_disasm.c
> > index 162d459..2ebbc98 100644
> > --- a/backend/src/backend/gen/gen_mesa_disasm.c
> > +++ b/backend/src/backend/gen/gen_mesa_disasm.c
> > @@ -265,7 +265,7 @@ static const char *access_mode[2] = {
> >    [1] = "align16",
> >  };
> >
> > -static const char *reg_encoding[8] = {
> > +static const char *reg_encoding[10] = {
> >    [0] = ":UD",
> >    [1] = ":D",
> >    [2] = ":UW",
> > @@ -273,10 +273,12 @@ static const char *reg_encoding[8] = {
> >    [4] = ":UB",
> >    [5] = ":B",
> >    [6] = ":DF",
> > -  [7] = ":F"
> > +  [7] = ":F",
> > +  [8] = ":Q",
> > +  [9] = ":UQ"
> >  };
> >
> > -int reg_type_size[8] = {
> > +int reg_type_size[10] = {
> >    [0] = 4,
> >    [1] = 4,
> >    [2] = 2,
> > @@ -284,7 +286,9 @@ int reg_type_size[8] = {
> >    [4] = 1,
> >    [5] = 1,
> >    [6] = 8,
> > -  [7] = 4
> > +  [7] = 4,
> > +  [8] = 8,
> > +  [9] = 8
> >  };
> >
> >  static const char *reg_file[4] = {
> > @@ -983,6 +987,7 @@ static int imm(FILE *file, uint32_t type, const
> > void*
> > inst)
> >        break;
> >      case GEN_TYPE_F:
> >        format(file, "%-gF", GEN_BITS_FIELD(inst, bits3.f));
> > +      break;
> >    }
> >    return 0;
> >  }
> > --
> > 1.7.9.5
> >
> >
> >
> > _______________________________________________
> > Beignet mailing list
> > Beignet at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/beignet
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list