[Beignet] version 2 of libva buffer sharing patch set

[Weng, Chuanbo]

That's ok. I'll re-org the files and import libva as submodule.
Any other comments for this patchset?

-----Original Message-----
From: Zhigang Gong [mailto:zhigang.gong at linux.intel.com] 
Sent: Thursday, January 08, 2015 10:25
To: Weng, Chuanbo
Cc: Gong, Zhigang; beignet at lists.freedesktop.org
Subject: Re: [Beignet] version 2 of libva buffer sharing patch set

But this will duplicate many third party code into beignet repo.
IMO, this is not a good manner. Considering what if we will write more examples and depdends on more third party code?

One alternative method is to create a third party submodule in examples directory, and could get libva source code automatically if user want to build libva example. Then we don't need to maintain these duplicate code in beignet.

What do you think?

On Thu, Jan 08, 2015 at 02:36:13AM +0000, Weng, Chuanbo wrote:
> Hi Zhigang,
> 	Yes, these files are referenced from libva directly. But they are not 
> one part of libva distribution, just files from libva unit test. I 
> think it's more convenient for users to try and build this example if 
> we copy these files to examples directory, or else  users should download libva source code by themselves.
> 
> -----Original Message-----
> From: Zhigang Gong [mailto:zhigang.gong at linux.intel.com]
> Sent: Wednesday, January 07, 2015 8:49
> To: Weng, Chuanbo
> Cc: beignet at lists.freedesktop.org; Zou, Nanhai; Gong, Zhigang
> Subject: Re: [Beignet] version 2 of libva buffer sharing patch set
> 
> Are the following files from libva directly:
>  examples/libva_buffer_sharing/sysdeps.h            |  79 ++++
>  examples/libva_buffer_sharing/va_display.c         | 166 ++++++++
>  examples/libva_buffer_sharing/va_display.h         |  64 +++
>  examples/libva_buffer_sharing/va_display_x11.c     | 139 +++++++
> 
> If so, why not just make this test depends on libva, and link to libva directly?
> 
> On Mon, Dec 22, 2014 at 10:37:53AM +0000, Weng, Chuanbo wrote:
> > Hi all,
> >                 Due to the test image size issue in the patch, I 
> > have made a new version of patches in order to switch to a smaller 
> > test image. If the patch is directly sent to mailing-list with git send-email, the test image can't be encoded in the correct format. So I put the patch on github.
> > Please use the following command to fetch the patch set:
> >                 git clone
> > https://github.com/Chuanbo-Weng/libva-buffer-sharing-patches.git
> > Or visit:
> >                 
> > https://github.com/Chuanbo-Weng/libva-buffer-sharing-patches
> > 
> > 
> > Thanks,
> > Chuanbo Weng
> 
> > _______________________________________________
> > Beignet mailing list
> > Beignet at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/beignet
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet