[Beignet] NUC5i7RYX Intel Iris Graphics 6100 support

[Yang, Rong R]

Yes, you are right, the device 162b is BDW and missing. The patch is ok.
In fact, this series device ids all are all missing, include 0x160B(GT1), 0x161B(GT2), 0x162B(GT3), could you send to a new version patch to include them?

The Failed test, test_load_program_from_spir has been fixed.
The other fails, maybe half’s precision issue, can you run these tests standalone(utest_run –c test_name) and print the input and output? We will check it.

Thanks.

From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Joseph Duchesne
Sent: Friday, July 10, 2015 05:48
To: beignet at lists.freedesktop.org
Subject: [Beignet] NUC5i7RYX Intel Iris Graphics 6100 support

I have a new Intel NUC model NUC5i7RYX that has a core i7 with "Iris graphics 6100". Trying to use beignet opencl installed from the latest source checkout, I got an "clinfo error, unknown device: 162b".

I poked around the source code and found that the device definition is missing for this GPU, so I added it. The patch is at the end of this message. The string contents and comments are entirely guesswork on my part, but make sense to me in any case. The patch appears to work fine.

utest results are the same as I get on an NUC5i5RYK which has the Intel HD Graphics 6000:
summary:
----------
  total: 762
  run: 761
  pass: 758
  fail: 3
  pass rate: 0.996058

Failed tests are:
compiler_half_math_sin()    [FAILED]
compiler_half_math_fmod()    [FAILED]
test_load_program_from_spir()    [FAILED]

I'm pretty sure I put things in the right place, and this allows me to use OpenCL for my purposes.

Patch file:
From e40baf3b4e175ed2cbfc996a14455c939d0bcaff Mon Sep 17 00:00:00 2001
From: robot <joseph at avidbots.com<mailto:joseph at avidbots.com>>
Date: Thu, 9 Jul 2015 17:44:07 -0400
Subject: [PATCH] added intel 6100 support

---
 src/cl_device_data.h | 2 ++
 src/cl_device_id.c   | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/src/cl_device_data.h b/src/cl_device_data.h
index b7b64c0..43b0110 100644
--- a/src/cl_device_data.h
+++ b/src/cl_device_data.h
@@ -203,6 +203,7 @@
 #define PCI_CHIP_BROADWLL_M_GT3       0x1622 /* Intel(R) Broadwell Mobile - Halo (EDRAM) - GT3 */
 #define PCI_CHIP_BROADWLL_D_GT3       0x1626 /* Intel(R) Broadwell U-Processor - GT3 */
 #define PCI_CHIP_BROADWLL_S_GT3       0x162A /* Intel(R) Broadwell Server - GT3 */
+#define PCI_CHIP_BROADWLL_N_GT3       0x162B /* Intel(R) Broadwell NUC 6100 - GT3 */
 #define PCI_CHIP_BROADWLL_W_GT3       0x162D /* Intel(R) Broadwell Workstation - GT3 */
 #define PCI_CHIP_BROADWLL_U_GT3       0x162E /* Intel(R) Broadwell ULX - GT3 */

@@ -224,6 +225,7 @@
   (devid == PCI_CHIP_BROADWLL_M_GT3 ||   \
    devid == PCI_CHIP_BROADWLL_D_GT3 || \
    devid == PCI_CHIP_BROADWLL_S_GT3 || \
+   devid == PCI_CHIP_BROADWLL_N_GT3 || \
    devid == PCI_CHIP_BROADWLL_W_GT3 || \
    devid == PCI_CHIP_BROADWLL_U_GT3)

diff --git a/src/cl_device_id.c b/src/cl_device_id.c
index f995550..8dae683 100644
--- a/src/cl_device_id.c
+++ b/src/cl_device_id.c
@@ -428,6 +428,8 @@ brw_gt2_break:
       DECL_INFO_STRING(brw_gt3_break, intel_brw_gt3_device, name, "Intel(R) HD Graphics BroadWell U-Processor GT2");
     case PCI_CHIP_BROADWLL_S_GT3:
       DECL_INFO_STRING(brw_gt3_break, intel_brw_gt3_device, name, "Intel(R) HD Graphics BroadWell Server GT2");
+    case PCI_CHIP_BROADWLL_N_GT3:
+      DECL_INFO_STRING(brw_gt3_break, intel_brw_gt3_device, name, "Intel(R) HD Graphics BroadWell NUC GT3");
     case PCI_CHIP_BROADWLL_W_GT3:
       DECL_INFO_STRING(brw_gt3_break, intel_brw_gt3_device, name, "Intel(R) HD Graphics BroadWell Workstation GT2");
     case PCI_CHIP_BROADWLL_U_GT3:
--
1.9.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20150715/0374ac03/attachment.html>