[Beignet] [PATCH] Reorder GBE_BIN_GENERATER arguments.

Yang, Rong R rong.r.yang at intel.com
Thu Jul 16 21:38:08 PDT 2015


LGTM, pushed, thanks.

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Koop Mast
> Sent: Tuesday, July 14, 2015 17:54
> To: beignet at lists.freedesktop.org
> Cc: Koop Mast
> Subject: [Beignet] [PATCH] Reorder GBE_BIN_GENERATER arguments.
> 
> Basically, it boils down to a difference in getopt(3). The
> getopt(3) on (Free)BSD will exit parsing arguments at the first unknown
> argument.
> 
> Signed-off-by: Koop Mast <kwm at rainbow-runner.nl>
> ---
>  src/CMakeLists.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 4e67c71..40a9afb
> 100644
> --- a/src/CMakeLists.txt
> +++ b/src/CMakeLists.txt
> @@ -16,13 +16,13 @@ foreach (KF ${KERNEL_FILES})
>      add_custom_command(
>        OUTPUT ${output_file}
>        COMMAND rm -rf ${output_file}
> -      COMMAND ${GBE_BIN_GENERATER} -s ${input_file} -o${output_file} -
> t${GEN_PCI_ID}
> +      COMMAND ${GBE_BIN_GENERATER} -s -o${output_file} -
> t${GEN_PCI_ID}
> + ${input_file}
>        DEPENDS ${input_file} ${GBE_BIN_FILE})
>    else(GEN_PCI_ID)
>      add_custom_command(
>        OUTPUT ${output_file}
>        COMMAND rm -rf ${output_file}
> -      COMMAND ${GBE_BIN_GENERATER} -s ${input_file} -o${output_file}
> +      COMMAND ${GBE_BIN_GENERATER} -s -o${output_file} ${input_file}
>        DEPENDS ${input_file} ${GBE_BIN_FILE})
>    endif(GEN_PCI_ID)
>  endforeach (KF)
> --
> 2.4.5
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list