[Beignet] [PATCH] GBE: fix one potential register spilling bug.
Zhigang Gong
zhigang.gong at linux.intel.com
Tue Jun 2 00:13:10 PDT 2015
Thanks for the careful review comment. Just fixed it and pushed.
On Tue, Jun 02, 2015 at 06:29:41AM +0000, Song, Ruiling wrote:
> > if ((regSize == ctx.getSimdWidth()/8 * GEN_REG_SIZE && family ==
> > ir::FAMILY_DWORD)
> > - || (regSize == 2 * ctx.getSimdWidth()/8 * GEN_REG_SIZE &&
> > family == ir::FAMILY_QWORD)) {
> > + || (regSize == 2 * ctx.getSimdWidth()/8 * GEN_REG_SIZE &&
> > family == ir::FAMILY_QWORD)
> > + && !selection.isPartialWrite(reg)) {
>
> Detect partial write through getOffsetReg() is OK for me.
> But the above if (a||b &&c) condition check should be if ( (a || b) &&c). other parts LGTM.
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
More information about the Beignet
mailing list