[Beignet] [PATCH] GBE: remove the unecessary type check for SEL instructio.

Song, Ruiling ruiling.song at intel.com
Sun Mar 1 23:47:54 PST 2015


LGTM

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Zhigang Gong
> Sent: Monday, March 02, 2015 9:19 AM
> To: beignet at lists.freedesktop.org
> Cc: Gong, Zhigang
> Subject: [Beignet] [PATCH] GBE: remove the unecessary type check for SEL
> instructio.
> 
> The backend SEL instruction could support bool type since we change the
> bool representation to normal
> S16 data type. Now let us remove this assertion check.
> 
> Signed-off-by: Zhigang Gong <zhigang.gong at intel.com>
> ---
>  backend/src/ir/instruction.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/backend/src/ir/instruction.cpp b/backend/src/ir/instruction.cpp
> index 928e365..1e1b040 100644
> --- a/backend/src/ir/instruction.cpp
> +++ b/backend/src/ir/instruction.cpp
> @@ -874,7 +874,6 @@ namespace ir {
>          if (UNLIKELY(checkRegisterData(family, regID, fn, whyNot) ==
> false))
>            return false;
>        }
> -      CHECK_TYPE(this->type, allButBool);
>        return true;
>      }
> 
> --
> 1.9.1
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list