[Beignet] [PATCH V2] GBE: Refine ir for memory operation like atomic/load/store

Yang, Rong R rong.r.yang at intel.com
Tue Nov 3 04:32:52 PST 2015


The patch LGTM, but has some reorder warning when compiler. And the patch conflict with "GBE: Fix unaligned load/store issues.", don't include float support. Can you send a new version.

/home/yr/maintain/beignet/backend/src/llvm/llvm_gen_backend.cpp:416:31: warning: ‘gbe::MemoryInstHelper::unit’ will be initialized after [-Wreorder]
       ir::Unit               &unit;
                               ^
/home/yr/maintain/beignet/backend/src/llvm/llvm_gen_backend.cpp:407:25: warning:   ‘bool gbe::MemoryInstHelper::legacyMode’ [-Wreorder]
       bool              legacyMode;
                         ^
/home/yr/maintain/beignet/backend/src/llvm/llvm_gen_backend.cpp:392:7: warning:   when initialized here [-Wreorder]

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Ruiling Song
> Sent: Monday, October 26, 2015 15:14
> To: beignet at lists.freedesktop.org
> Cc: Song, Ruiling
> Subject: [Beignet] [PATCH V2] GBE: Refine ir for memory operation like
> atomic/load/store
> 
> the legacyMode means what kind of address mode to choose.
> when legacyMode is true, we need to do complex bti analysis.
> 
> dynamicBti and staticBti are most for platforms before BDW.
> And stateless is for platform BDW+
> 
> v2:
>  only do analyzePointerOrigin() under legacyMode.
> 



More information about the Beignet mailing list