[Beignet] [PATCH] fix a long relative regreesion issue on BSW caused by local copy propagation
Guo Yejun
yejun.guo at intel.com
Wed Oct 14 18:48:13 PDT 2015
on bsw, for long data type, src and dst hstride must be aligned to
the same qword, so disable the copy propagation for following IRs.
MOV(8) %62<2>:UD : %34<8,8,1>:UD
MOV(8) %42<1>:L : %62<8,4,2>:UD
and also fix a typo issue in function CalculateElements
Signed-off-by: Guo Yejun <yejun.guo at intel.com>
---
backend/src/backend/gen_insn_selection.cpp | 2 +-
backend/src/backend/gen_insn_selection.hpp | 2 ++
backend/src/backend/gen_insn_selection_optimize.cpp | 8 +++++++-
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/backend/src/backend/gen_insn_selection.cpp b/backend/src/backend/gen_insn_selection.cpp
index 9714e3e..5125eb3 100644
--- a/backend/src/backend/gen_insn_selection.cpp
+++ b/backend/src/backend/gen_insn_selection.cpp
@@ -2140,7 +2140,7 @@ namespace gbe
this->opaque->setLongRegRestrict(true);
this->opaque->setSlowByteGather(true);
this->opaque->setHasHalfType(true);
- opt_features = SIOF_OP_AND_LOGICAL_SRCMOD;
+ opt_features = SIOF_OP_AND_LOGICAL_SRCMOD | SIOF_OP_MOV_LONG_REG_RESTRICT;
}
Selection9::Selection9(GenContext &ctx) : Selection(ctx) {
diff --git a/backend/src/backend/gen_insn_selection.hpp b/backend/src/backend/gen_insn_selection.hpp
index f313786..4efb80b 100644
--- a/backend/src/backend/gen_insn_selection.hpp
+++ b/backend/src/backend/gen_insn_selection.hpp
@@ -230,6 +230,8 @@ namespace gbe
//for OP_AND, on BDW+, SrcMod value indicates a logical source modifier
// on PRE-BDW, SrcMod value indicates a numeric source modifier
SIOF_OP_AND_LOGICAL_SRCMOD = 1 << 0,
+ //for OP_MOV, on BSW, for long data type, src and dst hstride must be aligned to the same qword
+ SIOF_OP_MOV_LONG_REG_RESTRICT = 1 << 1,
};
/*! Owns the selection engine */
diff --git a/backend/src/backend/gen_insn_selection_optimize.cpp b/backend/src/backend/gen_insn_selection_optimize.cpp
index 939dd18..fffc8b0 100644
--- a/backend/src/backend/gen_insn_selection_optimize.cpp
+++ b/backend/src/backend/gen_insn_selection_optimize.cpp
@@ -30,7 +30,7 @@ namespace gbe
elements |= (1 << offsetInType);
offsetInByte += hstride * elementSize;
}
- offsetInByte += vstride * elementSize;
+ base += vstride * elementSize;
}
return elements;
}
@@ -174,6 +174,12 @@ namespace gbe
if (insn.opcode == SEL_OP_AND && (info->replacement.absolute || info->replacement.negation))
return false;
+ if (features & SIOF_OP_MOV_LONG_REG_RESTRICT && insn.opcode == SEL_OP_MOV) {
+ const GenRegister& dst = insn.dst(0);
+ if (dst.isint64() && !info->replacement.isint64() && info->elements != CalculateElements(info->replacement, insn.state.execWidth))
+ return false;
+ }
+
if (info->replacementOverwritten)
return false;
--
1.9.1
More information about the Beignet
mailing list