[Beignet] [PATCH] set the pitch of image from buffer to the buffer's pitch.

Guo, Yejun yejun.guo at intel.com
Mon Oct 26 07:09:59 PDT 2015


One comment.

-----Original Message-----
From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of xionghu.luo at intel.com
Sent: Monday, October 26, 2015 3:51 PM
To: beignet at lists.freedesktop.org
Cc: Luo, Xionghu
Subject: [Beignet] [PATCH] set the pitch of image from buffer to the buffer's pitch.

From: Luo Xionghu <xionghu.luo at intel.com>

if image from buffer, the image's pitch should be same with buffer bo's row pitch.

Signed-off-by: Luo Xionghu <xionghu.luo at intel.com>
---
 src/cl_mem.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/cl_mem.c b/src/cl_mem.c index cb2af47..67fcf57 100644
--- a/src/cl_mem.c
+++ b/src/cl_mem.c
@@ -851,8 +851,15 @@ _cl_mem_new_image(cl_context ctx,
     if (aligned_pitch < pitch && enableUserptr)
       aligned_pitch = pitch;
[yejun] can the logic be merged here?

     //no need align the height if 2d image from buffer.
+    //the pitch should be same with buffer's pitch as they share same bo.
     if (image_type == CL_MEM_OBJECT_IMAGE2D && buffer != NULL)
+    {
+      if(aligned_pitch < pitch)
+      {
+        aligned_pitch = pitch;
+      }
       aligned_h = h;
+    }
     else
       aligned_h  = ALIGN(h, cl_buffer_get_tiling_align(ctx, CL_NO_TILE, 1));
   } else if (tiling == CL_TILE_X) {
--
1.9.1

_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list