[Beignet] [PATCH v2 2/4] Add extensions intel_accelerator and basic intel_motion_estimation.

[Guo, Yejun]

yes, we should remove assert here.

We have finished error check for CL_INVALID_IMAGE_FORMAT somewhere.

As for CL_INVALID_IMAGE_SIZE, actually the spec does not list any specific requirement for the image size, I talked with the extension contact, he thought it is reasonable to remove it. We can ignore this now.

-----Original Message-----
From: Song, Ruiling 
Sent: Monday, September 14, 2015 10:15 AM
To: Weng, Chuanbo; beignet at lists.freedesktop.org
Cc: Guo, Yejun; Weng, Chuanbo
Subject: RE: [Beignet] [PATCH v2 2/4] Add extensions intel_accelerator and basic intel_motion_estimation.

> --- a/src/cl_command_queue.c
> +++ b/src/cl_command_queue.c
> @@ -140,10 +140,18 @@
> cl_command_queue_bind_image(cl_command_queue queue, cl_kernel k)
> 
>      image = cl_mem_image(k->args[id].mem);
>      set_image_info(k->curbe, &k->images[i], image);
> -    cl_gpgpu_bind_image(gpgpu, k->images[i].idx, image->base.bo, image-
> >offset,
> -                        image->intel_fmt, image->image_type, image->bpp,
> -                        image->w, image->h, image->depth,
> -                        image->row_pitch, image->slice_pitch, (cl_gpgpu_tiling)image-
> >tiling);
> +    if(k->vme){
> +      assert((image->fmt.image_channel_order == CL_R) && (image-
> >fmt.image_channel_data_type == CL_UNORM_INT8));
Using an assert does not comply with:
https://www.khronos.org/registry/cl/extensions/intel/cl_intel_motion_estimation.txt
   - CL_INVALID_IMAGE_SIZE if an image object is specified as an argument value
      and the image dimensions (image width, height, specified or compute row 
      and/or slice pitch) are not supported by this built-in kernel, as listed 
      above.
    - CL_INVALID_IMAGE_FORMAT if an image object is specified as an argument 
      value and the image format is not one of the image formats supported by 
      this built-in kernel, as listed above.
You need also check invalid image size.

Thanks!
Ruiling