[Beignet] [Patch V2] GBE: correct the llvm.loop.unroll.enable meta.

Song, Ruiling ruiling.song at intel.com
Fri Dec 30 06:11:33 UTC 2016


> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of
> Yang Rong
> Sent: Thursday, December 29, 2016 6:32 PM
> To: beignet at lists.freedesktop.org
> Cc: Yang, Rong R <rong.r.yang at intel.com>
> Subject: [Beignet] [Patch V2] GBE: correct the llvm.loop.unroll.enable meta.
> 
> LLVM check has meta llvm.loop.unroll.enable and
> llvm.loop.unroll.disable or not.
> If llvm.loop.unroll.disable and llvm.loop.unroll.enable are both set,
> llvm.loop.unroll.disable will override llvm.loop.unroll.enable.
> 
> V2: don't add meta when not enable unroll, let llvm unroll pass to
> decide.
I think it is good to let llvm unroll pass to make the decision, that is through passing the expected unroll parameters.
We only try to optimize what we really want to unroll in this pass. The patch LGTM.

- Ruiling


More information about the Beignet mailing list