[Beignet] [PATCH] enable FP_CONTRACT on as default, and implemented with MAD

Guo, Yejun yejun.guo at intel.com
Tue Mar 8 06:52:08 UTC 2016


ping for push, thanks.

-----Original Message-----
From: Song, Ruiling 
Sent: Wednesday, March 02, 2016 4:22 PM
To: Guo, Yejun; beignet at lists.freedesktop.org
Cc: Guo, Yejun
Subject: RE: [Beignet] [PATCH] enable FP_CONTRACT on as default, and implemented with MAD

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf 
> Of Guo Yejun
> Sent: Monday, February 29, 2016 8:08 AM
> To: beignet at lists.freedesktop.org
> Cc: Guo, Yejun <yejun.guo at intel.com>
> Subject: [Beignet] [PATCH] enable FP_CONTRACT on as default, and 
> implemented with MAD
> 
> According to OpenCL spec, FP_CONTRACT is on as default, while 
> LLVM/clang just enabled it at http://reviews.llvm.org/D14200 at Nov 
> 2015. So we still need set this option explicitly now.
> 
> The implementation is hardware MAD instruction whose accuracy is 
> enough for FP_CONTRACT.
> 
> Passed test:  contractions of conformance test
> 
> Signed-off-by: Guo Yejun <yejun.guo at intel.com>

The solution looks good. LGTM

Thanks!
Ruiling


More information about the Beignet mailing list