[Beignet] [PATCH] Backend: Clang now support static, fix now

[Pan, Xiuli]

Hi Ruiling,

I will do some test. But I think I should try to find which clang version start to support static and may be use some macro to handle this.

Thanks
Xiuli 

-----Original Message-----
From: Song, Ruiling 
Sent: Tuesday, March 29, 2016 11:52 AM
To: Pan, Xiuli <xiuli.pan at intel.com>; beignet at lists.freedesktop.org
Cc: Pan, Xiuli <xiuli.pan at intel.com>
Subject: RE: [Beignet] [PATCH] Backend: Clang now support static, fix now

Hi Xiuli,

The patch is OK for me. I would like this to be merged into OCL20 branch first.
Have you done some test against master branch? I just want to make sure it does not break anything in OpenCL 1.2.

Thanks!
Ruiling

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf 
> Of Xiuli Pan
> Sent: Tuesday, March 22, 2016 2:09 PM
> To: beignet at lists.freedesktop.org
> Cc: Pan, Xiuli <xiuli.pan at intel.com>
> Subject: [Beignet] [PATCH] Backend: Clang now support static, fix now
> 
> From: Pan Xiuli <xiuli.pan at intel.com>
> 
> Signed-off-by: Pan Xiuli <xiuli.pan at intel.com>
> ---
>  backend/src/libocl/include/ocl_types.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/backend/src/libocl/include/ocl_types.h
> b/backend/src/libocl/include/ocl_types.h
> index 88e5642..2ae1562 100644
> --- a/backend/src/libocl/include/ocl_types.h
> +++ b/backend/src/libocl/include/ocl_types.h
> @@ -37,8 +37,6 @@
>  #define PURE __attribute__((pure))
>  #define CONST __attribute__((const))
>  #define INLINE_OVERLOADABLE inline
> __attribute__((overloadable,always_inline))
> -// FIXME, clang's opencl FE doesn't support static.
> -#define static
> 
>  
> //////////////////////////////////////////////////////////////////////
> ///////
>  // OpenCL built-in scalar data types
> --
> 2.5.0
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet