[Beignet] patch to get beignet to compile on gcc 3.5.0

[Pan, Xiuli]

Hi Sean,

I do find that in cmath the isnan and isinf is in std namespace even in gcc 5.2 , but strangely we haven’t facing this problem. I am using Ubuntu and I could not find any Arch Linux to have a test.
You patch can definitely solved the problem on arch linux, and could you send a patch using ‘git format-patch -s’ to this mail list so that we can easily merge it into the master branch.

Thanks
Xiuli

From: Sean Lynch [mailto:seanl at literati.org]
Sent: Tuesday, March 29, 2016 11:44 AM
To: Pan, Xiuli <xiuli.pan at intel.com>
Cc: beignet at lists.freedesktop.org
Subject: Re: [Beignet] patch to get beignet to compile on gcc 3.5.0

Sorry, I meant 5.3.0, and I'm probably mistaken about the compiler version being the cause. I was assuming it was the cause because the beignet AUR package used to compile just fine, and suddenly people started to complain about "isnan not declared in this scope" errors. See the comments on https://aur.archlinux.org/packages/beignet/?comments=all, which now applies my patch and seems to fix others' problems with this error. I am compiling on 64 bit Arch Linux.

On Mon, Mar 28, 2016 at 8:32 PM, Pan, Xiuli <xiuli.pan at intel.com<mailto:xiuli.pan at intel.com>> wrote:
Hi Sean,

I was quite confused with the gcc 3.5.0, I searched on gcc.gnu.org<http://gcc.gnu.org> and found there is no version named 3.5.0.
If you mean the newest version 5.3.0, I have built one release version and try to build beignet and there is no error. Could you post the change log or anything related to the “removal of isnan and friends from the global namespace”.

The git describe show something misleading may because we have not set any tags for our project. It’s a very good idea for us to have some tags for beignet and we will figure out how to add some.

Thanks
Xiuli

From: Beignet [mailto:beignet-bounces at lists.freedesktop.org<mailto:beignet-bounces at lists.freedesktop.org>] On Behalf Of Sean Lynch
Sent: Saturday, March 26, 2016 11:24 PM
To: beignet at lists.freedesktop.org<mailto:beignet at lists.freedesktop.org>
Subject: [Beignet] patch to get beignet to compile on gcc 3.5.0

Hi, folks. Due to the removal of isnan and friends from the global namespace, beignet's master does not currently compile on Arch Linux and probably other platforms using gcc 3.5.0 (not sure if this is when it started but at least on this version). The following patch prepends std:: to isnan and friends and makes beignet compile and, as far as I've been able to tell from my somewhat limited testing (generating simpex noise using Reikna), work.

https://gist.github.com/seanlynch/725e2999ba79c54ed3af

I have created a "beignet-git" package in the AUR (Arch User Repository) that applies this patch, but I'll remove the patch once it's applied.

Also, please let me know if I shouldn't be using the master branch for the package; the version numbers I'm getting from "git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'" look like "Release_v1.0.0.r676.gad86ed3" when I would have thought I'd see 1.1.1 in there. https://aur.archlinux.org/packages/beignet-git/

_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org<mailto:Beignet at lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/beignet

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/beignet/attachments/20160329/64d3f983/attachment.html>