[Beignet] [PATCH 1/4] prepare gen9 sends binary format and enable the ASM dump for sends

[Guo, Yejun]

ok

-----Original Message-----
From: Song, Ruiling 
Sent: Thursday, November 24, 2016 10:33 AM
To: Guo, Yejun; beignet at lists.freedesktop.org
Subject: RE: [Beignet] [PATCH 1/4] prepare gen9 sends binary format and enable the ASM dump for sends



> -----Original Message-----
> From: Guo, Yejun
> Sent: Thursday, November 24, 2016 10:21 AM
> To: Song, Ruiling <ruiling.song at intel.com>; 
> beignet at lists.freedesktop.org
> Subject: RE: [Beignet] [PATCH 1/4] prepare gen9 sends binary format 
> and enable the ASM dump for sends
> 
> thanks, and two inline comments, right?
yes
> 
> > +    string(file, "null");
> This is not a good idea. Please parse the instruction bits to know 
> whether it is the null register.
> [yejun] yes, when I did something like atomic which has return value, 
> I found it is not always null. So, I fixed this in another patch, locally now.
> 
> > +    format(file, "0x%x", gen9_insn->bits3.ud);
> "0x%08x" would be better.
> [yejun] agree, should I send a v2 patch, or fix it in the latter patch 
> together with the above issue?
It's better to send your V2 to fix both issues.
>