[Beignet] [PATCH] disable CMRT as default, since no real case reported

Guo, Yejun yejun.guo at intel.com
Wed Nov 30 08:34:48 UTC 2016


sure, let me send a v2 patch to add a new cmake option

-----Original Message-----
From: Yang, Rong R 
Sent: Wednesday, November 30, 2016 4:33 PM
To: Guo, Yejun; beignet at lists.freedesktop.org
Subject: RE: [Beignet] [PATCH] disable CMRT as default, since no real case reported

If disable it, can you add an explanation to readme or add a cmake option?

> -----Original Message-----
> From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf 
> Of Guo, Yejun
> Sent: Monday, November 21, 2016 10:55
> To: beignet at lists.freedesktop.org
> Subject: Re: [Beignet] [PATCH] disable CMRT as default, since no real 
> case reported
> 
> ping for review, thanks.
> 
> -----Original Message-----
> From: Guo, Yejun
> Sent: Tuesday, October 25, 2016 3:33 PM
> To: beignet at lists.freedesktop.org
> Cc: Guo, Yejun
> Subject: [PATCH] disable CMRT as default, since no real case reported
> 
> and this feature also sometimes introduces build issue.
> 
> Signed-off-by: Guo, Yejun <yejun.guo at intel.com>
> ---
>  CMakeLists.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt index d839f3f..039f9cd 
> 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -170,7 +170,9 @@ ELSE(DRM_INTEL_FOUND)
>  ENDIF(DRM_INTEL_FOUND)
> 
>  # CMRT
> -pkg_check_modules(CMRT libcmrt)
> +#disable CMRT as default, since we do not see real case, #while see 
> +build issue of this feature #pkg_check_modules(CMRT libcmrt)
>  IF(CMRT_FOUND)
>  INCLUDE_DIRECTORIES(${CMRT_INCLUDE_DIRS})
>  ENDIF(CMRT_FOUND)
> --
> 1.9.1
> 
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet


More information about the Beignet mailing list