[Beignet] Building beignet with OpenCL 2.0 support in distros

[Pan, Xiuli]

Hi all,

Thank you for  pay close attention to our latest release. We are very sorry that we are not very thoughtful about the package making things.

We did not have a performance test for OCL2.0 so we did not set it as a default option and we did not think about how to run a binary version on both old 1.2 devices and new 2.0 devices.
Thanks to Rebecca's patch to change the 1.2 and 2.0 backend on runtime, I have test it on skl and ivb and it works fine. There are few problems like utest for 2.0 and the #include "../src/cl_device_data.h" in backend.
I think we can add runtime check for 2.0 in utest and refine the function to pass the OCL20 support version from API runtime to backend.

And the default version problem can also be fixed by deleting the default setting to 200 at all, it seems all default OpenCL C version is 1.2 now.

Sorry for this inconvenience of release 1.3. We were planning to have 1.3.1 release with some performance patches, but now we may need have fix release 1.3.1, or you may think Rebecca's patch can solve your problem now?
As we are having the Chinese New Year holiday soon, we may need to decide it very quickly. Looking forward your replies!

Thanks
Xiuli


-----Original Message-----
From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf Of Rebecca N. Palmer
Sent: Sunday, January 22, 2017 7:07 AM
To: Bruno Pagani <bruno.n.pagani at gmail.com>; beignet at lists.freedesktop.org; ignatenko at redhat.com
Subject: Re: [Beignet] Building beignet with OpenCL 2.0 support in distros

As for the "OpenCL 2.0 = worse performance" problem, the OpenCL spec actually _requires_ 2.0 compilers to default to 1.2, and only enable
2.0 if explicitly asked to:
https://www.khronos.org/registry/OpenCL/specs/opencl-2.0.pdf page 203

beignet currently defaults to 2.0 if it is enabled, but this is easy to change: the default is set at backend/src/backend/program.cpp:1026

_______________________________________________
Beignet mailing list
Beignet at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet