<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.gmail-im
{mso-style-name:gmail-im;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I recheck the case, the origin asm is:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">So the problem is that mad need to spilt. And the liveness for these complex instruction should not be set to be reuseable.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">( 2606) mad(8) g4<1>:F g4.1<0,1,0>:F g127.7<0,1,0>:F g46:F { align16 WE_normal 1Q };<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">( 2608) mad(8) g5<1>:F g4.1<0,1,0>:F g127.7<0,1,0>:F g47:F { align16 WE_normal 2Q };<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Ruiling Song [mailto:ruiling.song83@gmail.com]
<br>
<b>Sent:</b> Wednesday, December 21, 2016 10:59 AM<br>
<b>To:</b> Pan, Xiuli <xiuli.pan@intel.com><br>
<b>Cc:</b> Song, Ruiling <ruiling.song@intel.com>; Yang, Rong R <rong.r.yang@intel.com>; beignet@lists.freedesktop.org<br>
<b>Subject:</b> Re: [Beignet] [PATCH] GBE: fix a src/dst register reuse bug.<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">2016-12-21 10:43 GMT+08:00 Pan, Xiuli <<a href="mailto:xiuli.pan@intel.com" target="_blank">xiuli.pan@intel.com</a>>:<o:p></o:p></p>
<div>
<div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">I got the point.<br>
In some case, such as block read gemm. We may get 16 mad with g4, thus there may be some other mad using g4.2 or g4.3 later.<br>
If we reuse the g4, the g4.2 or g4.3 may be overwrite. In this case may be g4.1 is just a scalar value, and g4.2 or g4.* can be some other scalar value. This fix check if the src and dst is all uniform. It should fix this case.<o:p></o:p></p>
</blockquote>
<div>
<div>
<p class="MsoNormal">but the original code only change the liveness of the g4.1 instead of directly re-use the source.<o:p></o:p></p>
</div>
<p class="MsoNormal">So the problems is that liveness is wrong for other scalar registers?<br>
<br>
- Ruiling <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><span class="gmail-im">-----Original Message-----</span><br>
<span class="gmail-im">From: Beignet [mailto:<a href="mailto:beignet-bounces@lists.freedesktop.org">beignet-bounces@lists.freedesktop.org</a>] On Behalf Of Song, Ruiling</span><br>
<span class="gmail-im">Sent: Tuesday, December 20, 2016 8:28 PM</span><br>
<span class="gmail-im">To: Yang, Rong R <<a href="mailto:rong.r.yang@intel.com">rong.r.yang@intel.com</a>>;
<a href="mailto:beignet@lists.freedesktop.org">beignet@lists.freedesktop.org</a></span><br>
<span class="gmail-im">Cc: Yang, Rong R <<a href="mailto:rong.r.yang@intel.com">rong.r.yang@intel.com</a>></span><o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">Subject: Re: [Beignet] [PATCH] GBE: fix a src/dst register reuse bug.<br>
<br>
<br>
<br>
> -----Original Message-----<br>
> From: Beignet [mailto:<a href="mailto:beignet-bounces@lists.freedesktop.org">beignet-bounces@lists.freedesktop.org</a>] On Behalf<br>
> Of Yang Rong<br>
> Sent: Tuesday, December 20, 2016 4:47 PM<br>
> To: <a href="mailto:beignet@lists.freedesktop.org">beignet@lists.freedesktop.org</a><br>
> Cc: Yang, Rong R <<a href="mailto:rong.r.yang@intel.com">rong.r.yang@intel.com</a>><br>
> Subject: [Beignet] [PATCH] GBE: fix a src/dst register reuse bug.<br>
><br>
> For case:<br>
> mad(8) g4<1>:F g4.1<0,1,0>:F g127.7<0,1,0>:F g46:F<br>
> src0 is uniform, dst is non-uniform, dst can't reuse the src0.<br>
why g4.0 cannot be reused here? What's wrong here?<br>
<br>
_______________________________________________<br>
Beignet mailing list<br>
<a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">https://lists.freedesktop.org/mailman/listinfo/beignet</a><br>
_______________________________________________<br>
Beignet mailing list<br>
<a href="mailto:Beignet@lists.freedesktop.org">Beignet@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/beignet" target="_blank">https://lists.freedesktop.org/mailman/listinfo/beignet</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>