[cairo-bugs] [Bug 15349] bad clipping with EXTEND_NONE

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=15349





--- Comment #4 from Carl Worth <cworth at cworth.org>  2008-04-04 21:05:30 PST ---
(In reply to comment #3)
> Created an attachment (id=15692)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=15692) [details]
> Patch tightning bounds in some cases
> 
> Ouch - a locking failure ;-(

Heh, sorry about that.

> I merged this residual with the current code, feel free to use or not
> use as you see fit. It's certainly debatable whether it's worthwhile
> or just possibly-bug-inducing complexity.

It's fine I think . But it makes me wonder if we shouldn't use a function like
that to fast-path to NEAREST for the actual rendering as well.

> P.S. - I'm not sure I entirely agree with the comment:
> 
>    (since currently no specific backends that could do custom
>    filters are calling _cairo_pattern_get_extents)
> 
> _cairo_pattern_get_extents() gets used via the "fallback" code for
> paint()/fill() for the Xlib backend, and the X server implementation
> is certainly free to implement a better FilterBest.

OK, a fair point. It did still like it would be a *lot* of code complexity for
zero benefit right now to add a new backend function for querying filter
expansion.

> P.P.S - as has been discussed previously:
> 
>    #define CAIRO_FILTER_DEFAULT CAIRO_FILTER_BEST
> 
>   in cairoint.h is a time-bomb waiting to happen. FILTER_DEFAULT
>   should be GOOD.

Yes, thanks for the reminder.

-Carl


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.