[cairo-commit] 2 commits - src/cairo-pdf-surface.c

Adrian Johnson ajohnson at kemper.freedesktop.org
Tue Feb 12 01:53:19 PST 2008


 src/cairo-pdf-surface.c |   24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

New commits:
commit fd3181c7bfdb468557d8c845a016b19c5a897955
Author: Adrian Johnson <ajohnson at redneon.com>
Date:   Tue Feb 12 20:22:38 2008 +1030

    PDF: Remove stale comments

diff --git a/src/cairo-pdf-surface.c b/src/cairo-pdf-surface.c
index 82a8f2d..46cae59 100644
--- a/src/cairo-pdf-surface.c
+++ b/src/cairo-pdf-surface.c
@@ -57,25 +57,7 @@
  *   could add generation counters to surfaces and remember the stream
  *   ID for a particular generation for a particular surface.
  *
- * - Images of other formats than 8 bit RGBA.
- *
  * - Backend specific meta data.
- *
- * - Surface patterns.
- *
- * - Should/does cairo support drawing into a scratch surface and then
- *   using that as a fill pattern?  For this backend, that would involve
- *   using a tiling pattern (4.6.2).  How do you create such a scratch
- *   surface?  cairo_surface_create_similar() ?
- *
- * - What if you create a similar surface and does show_page and then
- *   does show_surface on another surface?
- *
- * - Add test case for RGBA images.
- *
- * - Add test case for RGBA gradients.
- *
- * - Coordinate space for create_similar() args?
  */
 
 /*
@@ -1377,11 +1359,6 @@ _cairo_pdf_surface_emit_image (cairo_pdf_surface_t   *surface,
     cairo_pdf_resource_t smask = {0}; /* squelch bogus compiler warning */
     cairo_bool_t need_smask;
 
-    /* XXX: Need to rewrite this as a pdf_surface function with
-     * pause/resume of content_stream, (currently the only caller does
-     * the pause/resume already, but that is expected to change in the
-     * future). */
-
     /* These are the only image formats we currently support, (which
      * makes things a lot simpler here). This is enforced through
      * _cairo_pdf_surface_analyze_operation which only accept source surfaces of
commit bdb857a78b41d926b1c239cf988539842a72130b
Author: Adrian Johnson <ajohnson at redneon.com>
Date:   Tue Feb 12 20:19:03 2008 +1030

    PDF: Fix uninitialized variable in previous commit

diff --git a/src/cairo-pdf-surface.c b/src/cairo-pdf-surface.c
index 08e08c7..82a8f2d 100644
--- a/src/cairo-pdf-surface.c
+++ b/src/cairo-pdf-surface.c
@@ -3036,6 +3036,7 @@ _cairo_pdf_surface_emit_type1_font (cairo_pdf_surface_t		*surface,
 	return CAIRO_STATUS_SUCCESS;
 
     /* We ignore the zero-trailer and set Length3 to 0. */
+    length = subset->header_length + subset->data_length;
     status = _cairo_pdf_surface_open_stream (surface,
 					     NULL,
 					     TRUE,


More information about the cairo-commit mailing list