[cairo-commit] test/pdf-mime-data.c

Bryce Harrington bryce at kemper.freedesktop.org
Thu Jul 30 16:56:57 PDT 2015


 test/pdf-mime-data.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c04bd4308382db00347016e666f38fcfe8ee1f08
Author: Bryce Harrington <bryce at osg.samsung.com>
Date:   Thu Jul 30 16:45:15 2015 -0700

    test: Free the memory, not the pointer to the memory
    
    In read_file(), we see:
    
        *data = malloc (*len);
        ...
        if (fread(*data, *len, 1, fp) != 1) {
          free(data);
          ...
    
    The free call needs to be free(*data), to match the malloc call.
    
    Matthias Clasen found this via Coverity and proposed the fix.
    
    Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91381

diff --git a/test/pdf-mime-data.c b/test/pdf-mime-data.c
index fd5af1f..b49a1d1 100644
--- a/test/pdf-mime-data.c
+++ b/test/pdf-mime-data.c
@@ -82,7 +82,7 @@ read_file (const cairo_test_context_t *ctx,
     }
 
     if (fread(*data, *len, 1, fp) != 1) {
-	free (data);
+	free (*data);
 	fclose(fp);
 	cairo_test_log (ctx, "Could not read data from file %s\n", file);
 	return CAIRO_TEST_FAILURE;


More information about the cairo-commit mailing list