2 commits - src/cairo-xcb-connection-shm.c

[GitLab Mirror]

 src/cairo-xcb-connection-shm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a3ca983ec376693911604cacdceba4f4f2dcf75d
Merge: 2e2080247 a1c31f5ed
Author: Uli Schlachter <psychon at znc.in>
Date:   Tue May 27 16:02:14 2025 +0000

    Merge branch 'cm/fix-uaf-warning' into 'master'
    
    xcb: Fix a -Wuse-after-free=3 warning with GCC
    
    Closes #898
    
    See merge request cairo/cairo!623

commit a1c31f5ed5efb8705732a2aa6dd8ff97c4c58cac
Author: correctmost <126085-correctmost at users.noreply.gitlab.freedesktop.org>
Date:   Mon May 26 21:12:29 2025 -0400

    xcb: Fix a -Wuse-after-free=3 warning with GCC
    
    Closes #898

diff --git a/src/cairo-xcb-connection-shm.c b/src/cairo-xcb-connection-shm.c
index 140a73cd0..fda75cfa7 100644
--- a/src/cairo-xcb-connection-shm.c
+++ b/src/cairo-xcb-connection-shm.c
@@ -93,13 +93,13 @@ _cairo_xcb_connection_shm_get_image (cairo_xcb_connection_t *connection,
 							XCB_IMAGE_FORMAT_Z_PIXMAP,
 							shmseg, offset),
 				     NULL);
-    free (reply);
 
     if (!reply) {
 	/* an error here should be impossible */
 	return _cairo_error (CAIRO_STATUS_READ_ERROR);
     }
 
+    free (reply);
     return CAIRO_STATUS_SUCCESS;
 }