[cairo] new pattern interface patches and some great news about the OpenGL backend

Carl Worth cworth at east.isi.edu
Thu Apr 1 15:47:33 PST 2004

On Apr 2, David Reveman wrote:
 > On Thu, 2004-04-01 at 14:20 -0500, Carl Worth wrote:
 > ok, thanks for finding those issues.

You're welcome. No problem at all.

 > yes, same thing with cairo_gl_surface.c. Can I use the indent program
 > with some nice options for this or should I do it by hand? 

Sure. I usually just let my editor take care of it, but it looks like
the following is close enough for me:

    indent -i4 -bli0

 > > And what is the change to cairo_ft_font.c? A bug fix? It seems
 > > unrelated so please commit it separately from the rest.
 > It's needed for correct source offset in pattern surface. For linear and
 > radial patterns we only generate a pattern surface that is big enough to
 > cover the rendering area. Maybe I can get this source offset right in
 > some other way. I'll see what I can do.

Ah, since it is related, feel free to just leave it.

I looked at the SVG regressions a bit. So far, valgrind found a

	_cairo_color_init (&stop->color);

just before _cairo_color_set_rgb in cairo_pattern_add_color_stop.

And I noticed that a solid "red" pattern comes through as R=255, G=1,
B=1 instead of R=255, G=0, B=0. Haven't chased it further than that,
but it's also not a reason to hold up the commit.


More information about the cairo mailing list